feat: Warn on usage with plugins with SDK < v0.13 (#2696)

erezrokah · web-flow · commit a96e1ec483a4 · 2022-10-12T14:16:44.000Z
#### Summary Example: ![image](https://user-images.githubusercontent.com/26760571/195351567-102990a6-1c07-4353-a135-37531c103444.png) <!--
diff --git a/cli/cmd/sync.go b/cli/cmd/sync.go
@@ -21,6 +21,7 @@ cloudquery sync ./directory
 # Sync resources from directories and files
 cloudquery sync ./directory ./aws.yml ./pg.yml
 `
+	unknownFieldErrorPrefix = "code = InvalidArgument desc = failed to decode spec: json: unknown field "
 )
 
 func NewCmdSync() *cobra.Command {
@@ -129,6 +130,9 @@ func syncConnection(ctx context.Context, sourceSpec specs.Source, destinationsSp
 	g.Go(func() error {
 		defer close(resources)
 		if err := sourceClient.Sync(gctx, sourceSpec, resources); err != nil {
+			if isUnknownConcurrencyFieldError(err) {
+				return fmt.Errorf("unsupported version of source %s@%s. Please update to the latest version from https://cloudquery.io/docs/plugins/sources", sourceSpec.Name, sourceSpec.Version)
+			}
 			return fmt.Errorf("failed to sync source %s: %w", sourceSpec.Name, err)
 		}
 		return nil
@@ -196,3 +200,7 @@ func syncConnection(ctx context.Context, sourceSpec specs.Source, destinationsSp
 		Int("resources", totalResources).Uint64("errors", summary.Errors).Uint64("panic", summary.Panics).Uint64("failed_writes", failedWrites).Float64("time_took", tt.Seconds()).Msg("Sync completed successfully")
 	return nil
 }
+
+func isUnknownConcurrencyFieldError(err error) bool {
+	return strings.Contains(err.Error(), unknownFieldErrorPrefix+`"table_concurrency"`) || strings.Contains(err.Error(), unknownFieldErrorPrefix+`"resource_concurrency"`)
+}

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,7 @@ cloudquery sync ./directory`
`21`	`21`	`# Sync resources from directories and files`
`22`	`22`	`cloudquery sync ./directory ./aws.yml ./pg.yml`
`23`	`23`	`
	`24`	`+ unknownFieldErrorPrefix = "code = InvalidArgument desc = failed to decode spec: json: unknown field "`
`24`	`25`	`)`
`25`	`26`
`26`	`27`	`func NewCmdSync() *cobra.Command {`
`@@ -129,6 +130,9 @@ func syncConnection(ctx context.Context, sourceSpec specs.Source, destinationsSp`
`129`	`130`	`g.Go(func() error {`
`130`	`131`	`defer close(resources)`
`131`	`132`	`if err := sourceClient.Sync(gctx, sourceSpec, resources); err != nil {`
	`133`	`+ if isUnknownConcurrencyFieldError(err) {`
	`134`	`+ return fmt.Errorf("unsupported version of source %s@%s. Please update to the latest version from https://cloudquery.io/docs/plugins/sources", sourceSpec.Name, sourceSpec.Version)`
	`135`	`+ }`
`132`	`136`	`return fmt.Errorf("failed to sync source %s: %w", sourceSpec.Name, err)`
`133`	`137`	`}`
`134`	`138`	`return nil`
`@@ -196,3 +200,7 @@ func syncConnection(ctx context.Context, sourceSpec specs.Source, destinationsSp`
`196`	`200`	`Int("resources", totalResources).Uint64("errors", summary.Errors).Uint64("panic", summary.Panics).Uint64("failed_writes", failedWrites).Float64("time_took", tt.Seconds()).Msg("Sync completed successfully")`
`197`	`201`	`return nil`
`198`	`202`	`}`
	`203`	`+`
	`204`	`+func isUnknownConcurrencyFieldError(err error) bool {`
	`205`	+ return strings.Contains(err.Error(), unknownFieldErrorPrefix+`"table_concurrency"`) \|\| strings.Contains(err.Error(), unknownFieldErrorPrefix+`"resource_concurrency"`)
	`206`	`+}`