feat: Upgrade gremlin-go to latest minor (#22326)

murarustefaan · web-flow · commit a4c0a1fff61d · 2026-03-20T14:29:29.000Z
diff --git a/plugins/destination/gremlin/client/delete_stale.go b/plugins/destination/gremlin/client/delete_stale.go
@@ -2,6 +2,7 @@ package client
 
 import (
 	"context"
+	"time"
 
 	gremlingo "github.com/apache/tinkerpop/gremlin-go/v3/driver"
 	"github.com/cloudquery/plugin-sdk/v4/message"
@@ -16,11 +17,11 @@ func (c *Client) DeleteStale(_ context.Context, msgs message.WriteDeleteStales)
 	defer closer()
 
 	for _, msg := range msgs {
-		g := gremlingo.Traversal_().WithRemote(session).
+		g := gremlingo.Traversal_().With(session).
 			V().
 			HasLabel(msg.GetTable().Name).
 			Has(schema.CqSourceNameColumn.Name, msg.SourceName).
-			Has(schema.CqSyncTimeColumn.Name, gremlingo.P.Lt(msg.SyncTime)).
+			Has(schema.CqSyncTimeColumn.Name, gremlingo.P.Lt(msg.SyncTime.Truncate(time.Millisecond))).
 			SideEffect(AnonT.Drop())
 		if err := <-g.Iterate(); err != nil {
 			return err
diff --git a/plugins/destination/gremlin/client/read.go b/plugins/destination/gremlin/client/read.go
@@ -16,7 +16,7 @@ func (c *Client) Read(_ context.Context, table *schema.Table, res chan<- arrow.R
 	}
 	defer closer()
 
-	g := gremlingo.Traversal_().WithRemote(session).
+	g := gremlingo.Traversal_().With(session).
 		V().
 		HasLabel(table.Name).
 		Group().By(gremlingo.T.Id).
diff --git a/plugins/destination/gremlin/client/transformer.go b/plugins/destination/gremlin/client/transformer.go
@@ -40,7 +40,8 @@ func (c *Client) transformArr(arr arrow.Array, isCQTime bool) []any {
 			dbArr[i] = stripNulls(a.Value(i))
 		case *array.Timestamp:
 			if isCQTime {
-				dbArr[i] = a.Value(i).ToTime(a.DataType().(*arrow.TimestampType).Unit).UTC()
+				// Truncate to millisecond precision to match Gremlin's Java Date storage
+				dbArr[i] = a.Value(i).ToTime(a.DataType().(*arrow.TimestampType).Unit).UTC().Truncate(time.Millisecond)
 				continue
 			}
 			dbArr[i] = a.Value(i).ToTime(a.DataType().(*arrow.TimestampType).Unit).UTC().Format("2006-01-02 15:04:05.999999999")
diff --git a/plugins/destination/gremlin/client/write.go b/plugins/destination/gremlin/client/write.go
@@ -55,7 +55,7 @@ func (c *Client) WriteTableBatch(ctx context.Context, tableName string, msgs mes
 		}
 	}
 
-	g := gremlingo.Traversal_().WithRemote(session).V().HasLabel(tableName)
+	g := gremlingo.Traversal_().With(session).V().HasLabel(tableName)
 	for i := range rows {
 		g = g.V().HasLabel(tableName)
 		for _, colName := range pks {
diff --git a/plugins/destination/gremlin/docker-compose.yaml b/plugins/destination/gremlin/docker-compose.yaml
@@ -1,6 +1,6 @@
 services:
   gremlin:
-    image: tinkerpop/gremlin-server:3.7.1
+    image: tinkerpop/gremlin-server:3.8
     ports:
       - "8182:8182"
     networks:
diff --git a/plugins/destination/gremlin/go.mod b/plugins/destination/gremlin/go.mod
@@ -4,7 +4,7 @@ go 1.26.0
 
 require (
 	github.com/apache/arrow-go/v18 v18.5.2
-	github.com/apache/tinkerpop/gremlin-go/v3 v3.7.4
+	github.com/apache/tinkerpop/gremlin-go/v3 v3.8.0
 	github.com/aws/aws-sdk-go-v2 v1.41.3
 	github.com/aws/aws-sdk-go-v2/config v1.32.11
 	github.com/cenkalti/backoff/v4 v4.3.0
diff --git a/plugins/destination/gremlin/go.sum b/plugins/destination/gremlin/go.sum
@@ -11,8 +11,8 @@ github.com/apache/arrow/go/v13 v13.0.0-20230731205701-112f94971882 h1:mFDZW1FQk9
 github.com/apache/arrow/go/v13 v13.0.0-20230731205701-112f94971882/go.mod h1:W69eByFNO0ZR30q1/7Sr9d83zcVZmF2MiP3fFYAWJOc=
 github.com/apache/thrift v0.22.0 h1:r7mTJdj51TMDe6RtcmNdQxgn9XcyfGDOzegMDRg47uc=
 github.com/apache/thrift v0.22.0/go.mod h1:1e7J/O1Ae6ZQMTYdy9xa3w9k+XHWPfRvdPyJeynQ+/g=
-github.com/apache/tinkerpop/gremlin-go/v3 v3.7.4 h1:w4kbgY+klmw5WjcniKqhhfoSmbinhT3lc0CoF/AHMqI=
-github.com/apache/tinkerpop/gremlin-go/v3 v3.7.4/go.mod h1:hw4is2yHBjGOOoa9Z1sKckEJsH2bCXvq2biORjo32sM=
+github.com/apache/tinkerpop/gremlin-go/v3 v3.8.0 h1:uJc4o8uNme+NNMqyikEQd5w+uxPgEVYv7GRD0Mzemk4=
+github.com/apache/tinkerpop/gremlin-go/v3 v3.8.0/go.mod h1:aijnmD7bFPIqwllmJaJDY0zKJ/bvg+rcgiX7rFqurqI=
 github.com/apapsch/go-jsonmerge/v2 v2.0.0 h1:axGnT1gRIfimI7gJifB699GoE/oq+F2MU7Dml6nw9rQ=
 github.com/apapsch/go-jsonmerge/v2 v2.0.0/go.mod h1:lvDnEdqiQrp0O42VQGgmlKpxL1AP2+08jFMw88y4klk=
 github.com/aws/aws-sdk-go-v2 v1.41.3 h1:4kQ/fa22KjDt13QCy1+bYADvdgcxpfH18f0zP542kZA=

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ func (c Client) Read(_ context.Context, table schema.Table, res chan<- arrow.R`
`16`	`16`	`}`
`17`	`17`	`defer closer()`
`18`	`18`
`19`		`- g := gremlingo.Traversal_().WithRemote(session).`
	`19`	`+ g := gremlingo.Traversal_().With(session).`
`20`	`20`	`V().`
`21`	`21`	`HasLabel(table.Name).`
`22`	`22`	`Group().By(gremlingo.T.Id).`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ func (c *Client) WriteTableBatch(ctx context.Context, tableName string, msgs mes`
`55`	`55`	`}`
`56`	`56`	`}`
`57`	`57`
`58`		`- g := gremlingo.Traversal_().WithRemote(session).V().HasLabel(tableName)`
	`58`	`+ g := gremlingo.Traversal_().With(session).V().HasLabel(tableName)`
`59`	`59`	`for i := range rows {`
`60`	`60`	`g = g.V().HasLabel(tableName)`
`61`	`61`	`for _, colName := range pks {`