Skip to content

Commit 9927ede

Browse files
erezrokahpull[bot]
authored andcommitted
fix(gcp-resources): Change gcp_appengine_firewall_ingress_rules PK to _cq_id (#6531)
#### Summary The PK for `gcp_appengine_firewall_ingress_rules` was `project_id` which I think means we only save 1 firewall rule per project (in `overwrite*` modes). Doesn't seems like there's another field to use as a PK Non breaking as the data exists <!--
1 parent ff05db6 commit 9927ede

2 files changed

Lines changed: 3 additions & 6 deletions

File tree

plugins/source/gcp/docs/tables/gcp_appengine_firewall_ingress_rules.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@
22

33
https://cloud.google.com/appengine/docs/admin-api/reference/rest/v1/apps.firewall.ingressRules#FirewallRule
44

5-
The primary key for this table is **project_id**.
5+
The primary key for this table is **_cq_id**.
66

77
## Columns
88

99
| Name | Type |
1010
| ------------- | ------------- |
1111
|_cq_source_name|String|
1212
|_cq_sync_time|Timestamp|
13-
|_cq_id|UUID|
13+
|_cq_id (PK)|UUID|
1414
|_cq_parent_id|UUID|
15-
|project_id (PK)|String|
15+
|project_id|String|
1616
|priority|Int|
1717
|action|String|
1818
|source_range|String|

plugins/source/gcp/resources/services/appengine/firewall_ingress_rules.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,6 @@ func FirewallIngressRules() *schema.Table {
2525
Name: "project_id",
2626
Type: schema.TypeString,
2727
Resolver: client.ResolveProject,
28-
CreationOptions: schema.ColumnCreationOptions{
29-
PrimaryKey: true,
30-
},
3128
},
3229
},
3330
}

0 commit comments

Comments
 (0)