fix(main): Truncate sync time to microsecond (#13484)

candiduslynx · web-flow · commit 8f874b63bbd1 · 2023-08-31T08:53:01.000Z
Fixes #13457 If we have a destination that supports timestamps with precisions higher than microsecond (like MSSQL), we may end up removing all previously written data in `overwrite-delete-stale` mode. We already solved it once for Snowflake in #10354
diff --git a/cli/cmd/sync_v1.go b/cli/cmd/sync_v1.go
@@ -33,7 +33,8 @@ func syncConnectionV1(ctx context.Context, sourceClient *managedplugin.Client, d
 			}
 		}
 	}()
-	syncTime := time.Now().UTC()
+	// https://github.com/golang/go/issues/41087
+	syncTime := time.Now().UTC().Truncate(time.Microsecond)
 	destinationStrings := make([]string, len(destinationsClients))
 	for i := range destinationsClients {
 		destinationStrings[i] = destinationSpecs[i].VersionString()
diff --git a/cli/cmd/sync_v2.go b/cli/cmd/sync_v2.go
@@ -89,7 +89,8 @@ func syncConnectionV2(ctx context.Context, sourceClient *managedplugin.Client, d
 			}
 		}
 	}()
-	syncTime := time.Now().UTC()
+	// https://github.com/golang/go/issues/41087
+	syncTime := time.Now().UTC().Truncate(time.Microsecond)
 	destinationStrings := make([]string, len(destinationsClients))
 	for i := range destinationsClients {
 		destinationStrings[i] = destinationSpecs[i].VersionString()
diff --git a/cli/cmd/sync_v3.go b/cli/cmd/sync_v3.go
@@ -53,7 +53,8 @@ func syncConnectionV3(ctx context.Context, source v3source, destinations []v3des
 			}
 		}
 	}()
-	syncTime := time.Now().UTC()
+	// https://github.com/golang/go/issues/41087
+	syncTime := time.Now().UTC().Truncate(time.Microsecond)
 	sourceName := sourceSpec.Name
 	destinationStrings := make([]string, len(destinationsClients))
 	for i := range destinationsClients {

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,8 @@ func syncConnectionV1(ctx context.Context, sourceClient *managedplugin.Client, d`
`33`	`33`	`}`
`34`	`34`	`}`
`35`	`35`	`}()`
`36`		`- syncTime := time.Now().UTC()`
	`36`	`+ // https://github.com/golang/go/issues/41087`
	`37`	`+ syncTime := time.Now().UTC().Truncate(time.Microsecond)`
`37`	`38`	`destinationStrings := make([]string, len(destinationsClients))`
`38`	`39`	`for i := range destinationsClients {`
`39`	`40`	`destinationStrings[i] = destinationSpecs[i].VersionString()`
Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,8 @@ func syncConnectionV2(ctx context.Context, sourceClient *managedplugin.Client, d`
`89`	`89`	`}`
`90`	`90`	`}`
`91`	`91`	`}()`
`92`		`- syncTime := time.Now().UTC()`
	`92`	`+ // https://github.com/golang/go/issues/41087`
	`93`	`+ syncTime := time.Now().UTC().Truncate(time.Microsecond)`
`93`	`94`	`destinationStrings := make([]string, len(destinationsClients))`
`94`	`95`	`for i := range destinationsClients {`
`95`	`96`	`destinationStrings[i] = destinationSpecs[i].VersionString()`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,8 @@ func syncConnectionV3(ctx context.Context, source v3source, destinations []v3des`
`53`	`53`	`}`
`54`	`54`	`}`
`55`	`55`	`}()`
`56`		`- syncTime := time.Now().UTC()`
	`56`	`+ // https://github.com/golang/go/issues/41087`
	`57`	`+ syncTime := time.Now().UTC().Truncate(time.Microsecond)`
`57`	`58`	`sourceName := sourceSpec.Name`
`58`	`59`	`destinationStrings := make([]string, len(destinationsClients))`
`59`	`60`	`for i := range destinationsClients {`