fix(gcp-resources): Add project_id and name as PKs of gcp_run_locations (#6548)

erezrokah · web-flow · commit 88c1993a8284 · 2023-01-09T19:24:40.000Z
#### Summary

`gcp_run_locations` was missing PKs, this should be a non breaking change as the data exists

&lt;!--
diff --git a/plugins/source/gcp/docs/tables/gcp_run_locations.md b/plugins/source/gcp/docs/tables/gcp_run_locations.md
@@ -2,7 +2,7 @@
 
 https://cloud.google.com/run/docs/reference/rest/v1/projects.locations#Location
 
-The primary key for this table is **_cq_id**.
+The composite primary key for this table is (**project_id**, **name**).
 
 ## Relations
 
@@ -15,11 +15,11 @@ The following tables depend on gcp_run_locations:
 | ------------- | ------------- |
 |_cq_source_name|String|
 |_cq_sync_time|Timestamp|
-|_cq_id (PK)|UUID|
+|_cq_id|UUID|
 |_cq_parent_id|UUID|
-|project_id|String|
+|project_id (PK)|String|
+|name (PK)|String|
 |display_name|String|
 |labels|JSON|
 |location_id|String|
-|metadata|IntArray|
-|name|String|
+|metadata|IntArray|
diff --git a/plugins/source/gcp/resources/services/run/locations.go b/plugins/source/gcp/resources/services/run/locations.go
@@ -19,6 +19,17 @@ func Locations() *schema.Table {
 				Name:     "project_id",
 				Type:     schema.TypeString,
 				Resolver: client.ResolveProject,
+				CreationOptions: schema.ColumnCreationOptions{
+					PrimaryKey: true,
+				},
+			},
+			{
+				Name:     "name",
+				Type:     schema.TypeString,
+				Resolver: schema.PathResolver("Name"),
+				CreationOptions: schema.ColumnCreationOptions{
+					PrimaryKey: true,
+				},
 			},
 		},
 		Relations: []*schema.Table{
