fix: Flipped condition in query for SecretsManager.4 (#13864)

jon-s58 · web-flow · commit 76c21fbec6db · 2023-09-15T00:02:40.000Z
flipped < sign in the status column #13774
diff --git a/plugins/source/aws/policies/queries/secretsmanager/secrets_should_be_rotated_within_a_specified_number_of_days.sql b/plugins/source/aws/policies/queries/secretsmanager/secrets_should_be_rotated_within_a_specified_number_of_days.sql
@@ -7,7 +7,7 @@ select
     account_id,
     arn as resource_id,
     case when
-        (last_rotated_date is null and created_date > now() - INTERVAL '90 days')
-        or (last_rotated_date is not null and last_rotated_date > now() - INTERVAL '90 days')
+        (last_rotated_date is null and created_date < now() - INTERVAL '90 days')
+        or (last_rotated_date is not null and last_rotated_date < now() - INTERVAL '90 days')
     then 'fail' else 'pass' end as status
 from aws_secretsmanager_secrets
diff --git a/website/tables/aws/aws_secretsmanager_secrets.md b/website/tables/aws/aws_secretsmanager_secrets.md
@@ -108,11 +108,11 @@ SELECT
   CASE
   WHEN (
     last_rotated_date IS NULL
-    AND created_date > now() - '90 days'::INTERVAL
+    AND created_date < now() - '90 days'::INTERVAL
   )
   OR (
       last_rotated_date IS NOT NULL
-      AND last_rotated_date > now() - '90 days'::INTERVAL
+      AND last_rotated_date < now() - '90 days'::INTERVAL
     )
   THEN 'fail'
   ELSE 'pass'

Original file line number	Diff line number	Diff line change
`@@ -108,11 +108,11 @@ SELECT`
`108`	`108`	`CASE`
`109`	`109`	`WHEN (`
`110`	`110`	`last_rotated_date IS NULL`
`111`		`- AND created_date > now() - '90 days'::INTERVAL`
	`111`	`+ AND created_date < now() - '90 days'::INTERVAL`
`112`	`112`	`)`
`113`	`113`	`OR (`
`114`	`114`	`last_rotated_date IS NOT NULL`
`115`		`- AND last_rotated_date > now() - '90 days'::INTERVAL`
	`115`	`+ AND last_rotated_date < now() - '90 days'::INTERVAL`
`116`	`116`	`)`
`117`	`117`	`THEN 'fail'`
`118`	`118`	`ELSE 'pass'`