fix: Don't error on S3 buckets with Object Lock disabled (aws_s3_bucket_object_lock_configurations ) (#14726)

AshCorr · web-flow · commit 33280074c71e · 2023-10-19T14:10:48.000Z
#### Summary When syncing `aws_s3_bucket_object_lock_configurations` we call [GetObjectLockConfiguration](https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObjectLockConfiguration.html) on every bucket in an AWS account. However, unless Object Lock is enabled on an S3 bucket this endpoint will return a 404 which Cloudquery interprets as an error. As this is an optional feature that I don't think most people will have enabled I believe cloudquery shouldn't treat this as an error. ``` 2:19PM ERR table resolver finished with error error="operation error S3: GetObjectLockConfiguration, https response error StatusCode: 404, RequestID: (redacted), HostID: (redacted), api error ObjectLockConfigurationNotFoundError: Object Lock configuration does not exist for this bucket" client=(redacted) module=aws-src table=aws_s3_bucket_object_lock_configurations` ``` Part of #14652
diff --git a/plugins/source/aws/resources/services/s3/bucket_object_lock_configurations.go b/plugins/source/aws/resources/services/s3/bucket_object_lock_configurations.go
@@ -43,7 +43,7 @@ func fetchS3BucketObjectLockConfigurations(ctx context.Context, meta schema.Clie
 		o.Region = region.Value
 	})
 	if err != nil {
-		if client.IsAWSError(err, "NoSuchBucket") {
+		if client.IsAWSError(err, "NoSuchBucket", "ObjectLockConfigurationNotFound") {
 			return nil
 		}
 		return err

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ func fetchS3BucketObjectLockConfigurations(ctx context.Context, meta schema.Clie`
`43`	`43`	`o.Region = region.Value`
`44`	`44`	`})`
`45`	`45`	`if err != nil {`
`46`		`- if client.IsAWSError(err, "NoSuchBucket") {`
	`46`	`+ if client.IsAWSError(err, "NoSuchBucket", "ObjectLockConfigurationNotFound") {`
`47`	`47`	`return nil`
`48`	`48`	`}`
`49`	`49`	`return err`