fix(gcp-resources): Add project_id and name as PKs of gcp_iam_service_account_keys, remove service_account_unique_id from PKs (#6541)

erezrokah · web-flow · commit 00ca4378da71 · 2023-01-09T19:56:42.000Z
#### Summary

`gcp_iam_service_account_keys` used the parent resource `unique_id` as a primary key. This meant we can only sync 1 account key per account in `overwrite*` modes.
This PR makes it so `project_id` and `name` are the primary keys, removes `service_account_unique_id` as a primary (but keeps the data).

This should be a non breaking change

&lt;!--
diff --git a/plugins/source/gcp/docs/tables/gcp_iam_service_account_keys.md b/plugins/source/gcp/docs/tables/gcp_iam_service_account_keys.md
@@ -2,7 +2,7 @@
 
 https://cloud.google.com/iam/docs/reference/rest/v1/projects.serviceAccounts.keys#ServiceAccountKey
 
-The primary key for this table is **service_account_unique_id**.
+The composite primary key for this table is (**project_id**, **name**).
 
 ## Relations
 
@@ -16,9 +16,9 @@ This table depends on [gcp_iam_service_accounts](gcp_iam_service_accounts.md).
 |_cq_sync_time|Timestamp|
 |_cq_id|UUID|
 |_cq_parent_id|UUID|
-|project_id|String|
-|service_account_unique_id (PK)|String|
-|name|String|
+|project_id (PK)|String|
+|service_account_unique_id|String|
+|name (PK)|String|
 |key_algorithm|String|
 |public_key_data|IntArray|
 |valid_after_time|Timestamp|
diff --git a/plugins/source/gcp/resources/services/iam/service_account_keys.go b/plugins/source/gcp/resources/services/iam/service_account_keys.go
@@ -19,11 +19,19 @@ func ServiceAccountKeys() *schema.Table {
 				Name:     "project_id",
 				Type:     schema.TypeString,
 				Resolver: client.ResolveProject,
+				CreationOptions: schema.ColumnCreationOptions{
+					PrimaryKey: true,
+				},
 			},
 			{
 				Name:     "service_account_unique_id",
 				Type:     schema.TypeString,
 				Resolver: schema.ParentColumnResolver("unique_id"),
+			},
+			{
+				Name:     "name",
+				Type:     schema.TypeString,
+				Resolver: schema.PathResolver("Name"),
 				CreationOptions: schema.ColumnCreationOptions{
 					PrimaryKey: true,
 				},
