Conversation
3e43abc to
fc7f215
Compare
goruha
approved these changes
Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.3.0->0.5.0Release Notes
cloudposse/github-action-deploy-helmfile
v0.5.0Compare Source
Handle multiple matching ingresses for output-url @ozydingo (#35)
Github actions cannot support having multiple output urls for an environment. Switch the strategy to use
jq'sfirstfunction so that at least some valid URL is displayed if present. Punts on how to determine which URL would be preferred in the case of multiple.what
webapp-urlwhen a deployment has multiple ingresseswhy
This causes the github action to fail to display the environment url
The URL does not display:
jqfromjsonpathsince it supportsfirsteven if there are no matches.jsonpathusing[0], on the other hand, will blow uptesting
Here is a PR that uses the new code, and is showing the preview env URL successfully.
references
v0.4.0Compare Source
Use ECR alpine image @goruha (#33)
what
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.