Skip to content

Change error behavior in terraform-ci#33

Merged
max-lobur merged 1 commit intomainfrom
change_err_behavior
Mar 30, 2023
Merged

Change error behavior in terraform-ci#33
max-lobur merged 1 commit intomainfrom
change_err_behavior

Conversation

@max-lobur
Copy link
Contributor

@max-lobur max-lobur commented Mar 30, 2023

what

  • Remove continue on error

why

  • It makes the workflow have result 'success' even if that step failed
  • Initially I had this when all of these jobs were steps in my testing environment, and I needed to ensure I run lint even if format failed. It's not needed anymore because these are now jobs and they all run in parallel unconditionally anyways.

@max-lobur max-lobur changed the title Change error behavior Change error behavior in terraform-ci Mar 30, 2023
@max-lobur max-lobur force-pushed the change_err_behavior branch from 6e869ea to 8d48059 Compare March 30, 2023 13:17
@max-lobur max-lobur merged commit 19e6133 into main Mar 30, 2023
@max-lobur max-lobur deleted the change_err_behavior branch March 30, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants