Skip to content

Revert "Colorize Atmos Describe Commands when TTY attached"#917

Merged
aknysh merged 1 commit intomainfrom
revert-907-DEV-2876/feat-tty
Jan 6, 2025
Merged

Revert "Colorize Atmos Describe Commands when TTY attached"#917
aknysh merged 1 commit intomainfrom
revert-907-DEV-2876/feat-tty

Conversation

@Cerebrovinny
Copy link
Collaborator

@Cerebrovinny Cerebrovinny commented Jan 6, 2025 •
edited by coderabbitai bot
Loading

Reverts #907

Summary by CodeRabbit

  • Removed Features

    • Removed syntax highlighting configuration for terminal output
    • Eliminated terminal settings related to code highlighting

  • Configuration Changes

    • Simplified configuration management for terminal settings
    • Restructured settings schema to remove highlighting-related options

  • Documentation

    • Removed documentation for terminal syntax highlighting configuration

The changes represent a significant simplification of terminal output and configuration handling, removing syntax highlighting capabilities from the application.

@mergify mergify bot added the triage Needs triage label Jan 6, 2025
@Cerebrovinny Cerebrovinny marked this pull request as ready for review January 6, 2025 20:44
@Cerebrovinny Cerebrovinny requested a review from a team as a code owner January 6, 2025 20:44
@aknysh aknysh added the no-release Do not create a new release (wait for additional code changes) label Jan 6, 2025
@aknysh aknysh merged commit a9b22a1 into main Jan 6, 2025
@mergify mergify bot removed the triage Needs triage label Jan 6, 2025
@aknysh aknysh deleted the revert-907-DEV-2876/feat-tty branch January 6, 2025 20:47
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 6, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request represents a significant refactoring of Atmos CLI's terminal and configuration handling, specifically removing syntax highlighting and terminal settings from the core configuration. The changes span multiple files including atmos.yaml, configuration schemas, and utility functions, effectively stripping out previous syntax highlighting and terminal-specific configuration mechanisms.

Changes

File Change Summary
atmos.yaml Removed terminal syntax highlighting configuration section
pkg/config/config.go Removed Settings field from default CLI configuration
pkg/schema/schema.go Restructured configuration structs, changed pointer types to value types
pkg/utils/highlight_utils.go Completely deleted file containing syntax highlighting utilities
pkg/utils/json_utils.go Removed JSON highlighting logic
pkg/utils/yaml_utils.go Removed YAML highlighting logic
website/docs/cli/configuration/terminal.mdx Deleted documentation for terminal configuration

Assessment against linked issues

Objective Addressed Explanation
Colorize Atmos Describe Commands [DEV-2876] ❌ Syntax highlighting functionality has been completely removed
Support configurable syntax highlighting options ❌ Configuration and highlighting code have been deleted
Conditional highlighting based on TTY ❌ TTY-based highlighting mechanism eliminated

Possibly related PRs

Suggested reviewers

  • osterman

The changes appear to be a significant regression in terms of the original feature request for syntax highlighting. The PR removes all previously implemented functionality for terminal output customization and syntax highlighting, which contradicts the objectives of the linked issue (DEV-2876).

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d93ce1 and 14e376e.

📒 Files selected for processing (7)
  • atmos.yaml (0 hunks)
  • pkg/config/config.go (1 hunks)
  • pkg/schema/schema.go (3 hunks)
  • pkg/utils/highlight_utils.go (0 hunks)
  • pkg/utils/json_utils.go (1 hunks)
  • pkg/utils/yaml_utils.go (1 hunks)
  • website/docs/cli/configuration/terminal.mdx (0 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or @auto-summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @auto-title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Jan 7, 2025

These changes were released in v1.137.0.

@coderabbitai coderabbitai bot mentioned this pull request Oct 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aknysh aknysh aknysh approved these changes

Assignees

No one assigned

Labels

no-release Do not create a new release (wait for additional code changes)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Cerebrovinny @aknysh