pkg/schema/schema.go (1)

79-81: Consider adding field documentation.

The ShellConfig struct is well-designed with a focused responsibility. To maintain consistency with Go best practices, consider adding a documentation comment to describe the purpose of the Prompt field.

 type ShellConfig struct {
+    // Prompt defines the custom shell prompt string. If empty, the default prompt is used.
     Prompt string `yaml:"prompt" json:"prompt" mapstructure:"prompt"`
 }

internal/exec/shell_utils.go (1)

158-160: 💡 Codebase verification

⚠️ Potential issue

Shell prompt environment variable needs PS1 prefix

Greetings, fellow code warrior! Our reconnaissance has revealed that the shell prompt is indeed being set without the crucial PS1= prefix. The configuration struct shows it's a raw string value, and there are no existing PS1 environment variable settings in the codebase.

Let's fortify this code:

 if cliConfig.Components.Terraform.Shell.Prompt != "" {
-    componentEnvList = append(componentEnvList, cliConfig.Components.Terraform.Shell.Prompt)
+    componentEnvList = append(componentEnvList, fmt.Sprintf("PS1=%s", cliConfig.Components.Terraform.Shell.Prompt))
 }

This change:

• Properly formats the shell prompt as an environment variable
• Maintains compatibility with standard shell behavior
• Ensures the prompt will be correctly interpreted by the shell

🔗 Analysis chain

Ensure proper shell prompt environment variable format

Greetings, warrior! While the implementation aligns well with making the prompt optional, we should ensure the prompt is properly formatted when added to the environment variables.

Consider this battle-tested approach:

 if cliConfig.Components.Terraform.Shell.Prompt != "" {
-    componentEnvList = append(componentEnvList, cliConfig.Components.Terraform.Shell.Prompt)
+    componentEnvList = append(componentEnvList, fmt.Sprintf("PS1=%s", cliConfig.Components.Terraform.Shell.Prompt))
 }

This ensures:

1. The prompt is properly prefixed with PS1=
2. Consistent behavior across different shells

Let's verify the shell prompt handling in other parts of the codebase:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for other shell prompt configurations
rg -l 'PS1=' 

# Search for any shell environment variable settings
ast-grep --pattern 'componentEnvList = append($_, $_)'

Length of output: 1003

---

Script:

#!/bin/bash
# Let's check the configuration struct to understand how the prompt is defined
rg -A 5 "type.*Shell.*struct" 

# Also check for any documentation about the shell prompt format
rg -i "shell.*prompt|prompt.*shell" 

Length of output: 722

internal/exec/shell_utils.go (1)

159-162: Document the default prompt behavior.

Since this change introduces configurable prompts, we should ensure the behavior is well-documented. Consider adding code comments explaining:

• The default behavior when no prompt is specified
• The format expectations for custom prompts
• Any limitations or security considerations

+// hasCustomShellPrompt determines if a user-defined shell prompt should be used.
+// When no prompt is specified, the default Terraform shell prompt is maintained.
+// Custom prompts should avoid shell metacharacters for security.
 hasCustomShellPrompt := cliConfig.Components.Terraform.Shell.Prompt != ""

pkg/schema/schema.go (1)

79-81: LGTM! Well-structured ShellConfig type.

The new ShellConfig type is cleanly defined with appropriate struct tags. The Prompt field provides a clear configuration point for customizing the shell prompt.

Consider adding validation for the prompt string in the future if there are any format requirements or restrictions that should be enforced.

Configuration used: .coderabbit.yaml
Review profile: CHILL