internal/exec/vendor_model.go (1)

148-148: Add missing space in completion message

There's a missing space after the period in the string "Vendored %d components.Failed to vendor %d components.\n", which causes the message to read incorrectly. Adding a space will improve readability.

Apply this diff to fix the formatting:

return doneStyle.Render(fmt.Sprintf("Vendored %d components.Failed to vendor %d components.\n", n-m.failedPkg, m.failedPkg))
+return doneStyle.Render(fmt.Sprintf("Vendored %d components. Failed to vendor %d components.\n", n-m.failedPkg, m.failedPkg))

internal/exec/vendor_model_component.go (5)

23-34: Export pkgComponentVendor struct

If there's a possibility of using pkgComponentVendor outside this package in the future, consider exporting it by capitalizing the struct name. Adding comments to structs and fields will also enhance code readability.

---

135-137: Add missing space in status message

There's a missing space after the period in the status message. This will improve the readability of the output.

-return doneStyle.Render(fmt.Sprintf("Vendored %d components.Failed to vendor %d components.\n", n-m.failedPkg, m.failedPkg))
+return doneStyle.Render(fmt.Sprintf("Vendored %d components. Failed to vendor %d components.\n", n-m.failedPkg, m.failedPkg))

---

166-199: Refactor to eliminate duplicate code in downloadComponentAndInstall

The function downloadComponentAndInstall contains similar code blocks for handling components and mixins. Refactoring can reduce duplication and simplify maintenance.

Here's a possible refactor:

 func downloadComponentAndInstall(p pkgComponentVendor, dryRun bool, cliConfig schema.CliConfiguration) tea.Cmd {
     return func() tea.Msg {
         if dryRun {
             time.Sleep(100 * time.Millisecond)
             return installedPkgMsg{
                 err:  nil,
                 name: p.name,
             }
         }

-        if p.IsComponent {
-            err := installComponent(p, cliConfig)
-            if err != nil {
-                return installedPkgMsg{
-                    err:  err,
-                    name: p.name,
-                }
-            }
-            return installedPkgMsg{
-                err:  nil,
-                name: p.name,
-            }
-        }
-        if p.IsMixins {
-            err := installMixin(p, cliConfig)
-            if err != nil {
-                return installedPkgMsg{
-                    err:  err,
-                    name: p.name,
-                }
-            }
-            return installedPkgMsg{
-                err:  nil,
-                name: p.name,
-            }
-        }
+        var err error
+        if p.IsComponent {
+            err = installComponent(p, cliConfig)
+        } else if p.IsMixins {
+            err = installMixin(p, cliConfig)
+        } else {
+            err = fmt.Errorf("unknown install operation")
+        }
         return installedPkgMsg{
             err:  err,
             name: p.name,
         }
     }
 }

---

258-259: Include package type in error message

Adding the package type to the error message will help in debugging unknown package types.

-return fmt.Errorf("unknown package type")
+return fmt.Errorf("unknown package type: %v", p.pkgType)

---

297-298: Include package type in error message

Similarly, in installMixin, include the package type in the error message for better clarity.

-return fmt.Errorf("unknown package type")
+return fmt.Errorf("unknown package type: %v", p.pkgType)

internal/exec/vendor_component_utils.go (3)

96-105: Implement ExecuteStackVendorInternal function

The ExecuteStackVendorInternal function currently returns a "not supported yet" error. Consider implementing the necessary logic or providing a more detailed message.

Would you like assistance in drafting the implementation or creating a GitHub issue to track this task?

---

343-343: Wrap error with %w for proper error handling

To enable error unwrapping, replace %v with %w when formatting errors.

Apply this diff:

- return fmt.Errorf("error initializing model: %v", err)
+ return fmt.Errorf("error initializing model: %w", err)

---

341-345: Handle errors from the TUI run

Ensure that errors from tea.NewProgram(model).Run() are properly handled to maintain robustness.

Apply this diff:

if _, err := tea.NewProgram(model).Run(); err != nil {
-   return fmt.Errorf("running download error: %w", err)
+   return fmt.Errorf("error running TUI program: %w", err)
}

Configuration used: .coderabbit.yaml
Review profile: CHILL