Files that changed from the base of the PR and between cfa2f21 and 10f8570.

• internal/exec/terraform.go (3 hunks)

internal/exec/terraform.go (2)

24-24: LGTM: New constant for the --everything flag.

The new constant everything is well-named and consistent with other constant declarations in the file. It correctly represents the --everything flag mentioned in the PR objectives.

---

24-24: Summary: Successfully implemented the --everything flag for Terraform state cleaning.

The changes in this file successfully implement the new --everything flag for the atmos terraform clean command as described in the PR objectives. The implementation is well-integrated into the existing code structure and follows the established patterns in the codebase.

Key points:

1. A new constant everything is added to represent the flag.
2. The clean subcommand logic is extended to handle the new flag.
3. When the flag is present, the code correctly targets and deletes the specific Terraform state folder for the component.

These changes enhance the Atmos tool's functionality by providing users with more control over cleaning Terraform state files, which can be beneficial in testing scenarios as mentioned in the PR description.

Also applies to: 107-114

Files that changed from the base of the PR and between 10f8570 and 594be52.

• internal/exec/terraform.go (2 hunks)

internal/exec/terraform.go (2)

24-24: LGTM: New constant for the --everything flag.

The addition of the everything constant with the value "--everything" is appropriate and aligns with the PR objectives.

---

Line range hint 1-669: Overall: Implementation meets PR objectives.

The changes successfully implement the --everything flag functionality for the clean subcommand as described in the PR objectives. The new constant and the modifications to the ExecuteTerraform function are correct and well-integrated into the existing code structure. With the minor suggestion for adding a comment addressed, this implementation is ready for merging.

Files that changed from the base of the PR and between 594be52 and 447105b.

• internal/exec/path_utils.go (2 hunks)
• internal/exec/terraform.go (3 hunks)
• internal/exec/utils.go (2 hunks)

internal/exec/terraform.go (4)

24-24: LGTM: Addition of everythingFlag constant

The new constant everythingFlag is correctly defined and follows the existing naming convention for flags in this file. This addition improves code readability and maintainability by centralizing the flag definition.

---

76-83: LGTM: Updated ProcessStacks call and error handling

The changes to the ProcessStacks function call and the subsequent error handling are appropriate. The introduction of the CheckStack parameter allows for more flexible behavior when processing stacks, which aligns well with the new --everything flag functionality.

---

Line range hint 1-644: Overall assessment: Implementation aligns with PR objectives

The changes to internal/exec/terraform.go successfully implement the --everything flag functionality for the clean subcommand as described in the PR objectives. The code is well-structured and covers the required scenarios for cleaning Terraform state files.

Key points:

1. The everythingFlag constant is correctly defined.
2. The logic for handling the --everything flag is properly integrated into the ExecuteTerraform function.
3. The implementation covers scenarios for cleaning all components, a specific component, or a specific component and stack.

Minor improvements suggested:

1. Remove a debug print statement.
2. Consider enhancing error handling in some cases.
3. Verify the implementation of new helper functions used in the changes.

Overall, the changes appear to meet the requirements and improve the functionality of the Atmos tool for Terraform state file management.

---

110-144: LGTM: Implementation of --everything flag for clean subcommand

The implementation of the --everything flag for the clean subcommand is comprehensive and aligns well with the PR objectives. It correctly handles different scenarios such as cleaning all components, a specific component, or a specific component and stack.

A few points to consider:

1. The functions deleteFilesAndFoldersRecursive and findFoldersNamesWithPrefix are used but not defined in this file. Could you provide information about where these functions are defined and their exact behavior?

2. The current error handling only logs warnings without stopping execution. Consider whether some errors should halt the process instead of continuing.

To verify the implementation of the new functions, please run the following script:

This will help ensure that these functions are properly defined and available for use in this context.

✅ Verification successful

LGTM: Implementation of --everything flag for clean subcommand

The implementation of the --everything flag for the clean subcommand is comprehensive and aligns well with the PR objectives. It correctly handles different scenarios such as cleaning all components, a specific component, or a specific component and stack.

A few points to consider:

• The functions deleteFilesAndFoldersRecursive and findFoldersNamesWithPrefix are defined in internal/exec/path_utils.go, ensuring their availability and correctness.
• The current error handling only logs warnings without stopping execution. Consider whether some errors should halt the process instead of continuing to enhance reliability.

To further improve, you might want to evaluate the error handling strategy to determine if certain failures should prevent the continuation of the cleanup process.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for the definitions of the new functions
echo "Searching for deleteFilesAndFoldersRecursive function:"
rg --type go "func deleteFilesAndFoldersRecursive"

echo "Searching for findFoldersNamesWithPrefix function:"
rg --type go "func findFoldersNamesWithPrefix"

Length of output: 537

internal/exec/path_utils.go (1)

139-175: Avoid using filepath.Walk due to potential performance issues.

Using filepath.Walk can be inefficient for large directory structures. Since we only need to check immediate subdirectories, consider using os.ReadDir for better performance.

[performance]

Apply this change to improve efficiency:

subDirs, err := os.ReadDir(basePath)
if err != nil {
	return fmt.Errorf("error reading base path %s: %w", basePath, err)
}

for _, subDir := range subDirs {
	if subDir.IsDir() {
		subDirPath := filepath.Join(basePath, subDir.Name())
		for _, item := range items {
			fullPath := filepath.Join(subDirPath, item)
			// Proceed with deletion logic
		}
	}
}

This avoids recursively walking through the entire directory structure.

Files that changed from the base of the PR and between 447105b and ff42d22.

• internal/exec/help.go (2 hunks)
• internal/exec/path_utils.go (2 hunks)

internal/exec/help.go (2)

77-78: Approved: Added information about deleting state files

The addition of information about deleting the 'terraform.tfstate.d' folder when using the --everything flag is consistent with the PR objectives and provides crucial information about the expanded functionality of the clean command.

---

Line range hint 33-84: Overall assessment: Significant improvement in help messages

The changes to the processHelp function in internal/exec/help.go have significantly enhanced the clarity and comprehensiveness of the help messages for the atmos terraform clean command. These improvements include:

1. Detailed explanation of the --everything flag's functionality
2. Introduction of the --skip-lock-file flag
3. Clear description of the command's behavior when no component or stack is specified
4. Addition of a link to the documentation for further details

These enhancements align perfectly with the PR objectives and will greatly improve the user experience by providing more accurate and detailed information about the command's capabilities and usage.

internal/exec/path_utils.go (1)

92-126: findFoldersNamesWithPrefix function implementation looks good

The function correctly finds folders with the specified prefix in both the root directory and its immediate subdirectories. Error handling and directory traversal are appropriately implemented.

Files that changed from the base of the PR and between ff42d22 and 23b320a.

• internal/exec/path_utils.go (2 hunks)
• internal/exec/terraform.go (3 hunks)
• internal/exec/utils.go (2 hunks)

internal/exec/terraform.go (3)

24-24: LGTM: Addition of everythingFlag constant

The new constant everythingFlag is correctly defined and aligns with the PR objectives to introduce a comprehensive cleaning option.

---

Line range hint 144-193: LGTM: Preservation of existing cleaning logic

The existing cleaning logic for .terraform folder, .terraform.lock.hcl file, and other artifacts is preserved. This maintains backwards compatibility while the new --everything flag logic complements the existing process.

---

Line range hint 1-1000: Overall LGTM: Well-implemented --everything flag for Terraform clean

The implementation of the --everything flag for the Terraform clean subcommand is well-done and aligns closely with the PR objectives. The code is structured logically, follows existing patterns, and maintains backwards compatibility. Error handling and logging are appropriately implemented.

Minor suggestions for improvement:

1. Use camelCase for local variables (needProcessStacks, checkStack).
2. Rename listOfClear to filesToClear for better clarity.

These small changes would enhance readability and consistency with Go naming conventions.

internal/exec/utils.go (2)

394-397: LGTM!

The added condition correctly allows the function to proceed without error when checkStack is false and no stacks are found. This enhances the flexibility for operations that don't require a stack.

---

1003-1009: LGTM!

The updated argument parsing logic now properly differentiates between options and component names. This improves the robustness and clarity of the function.