Conversation
nitrocode
approved these changes
Jul 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
depscalculationwhy
metadata.inheritsand the stack imported the YAML file(s) where the inherited YAML components are defined, add the imported YAML files to thedepslabelsdepscalculation. All imported YAML files where the base YAML components were defined were not included in thedepslabels (and the YAML files were missed from the Spacelift dependencies)For example:
In the above config,
test/test-component-override-3"inheritstest/test-component-override-2YAML component.Part of the config for
test/test-component-override-2YAML component is defined inservice-1-override-2.yamlfile:the
service-1-override-2.yamlfile was not included in thedepslabels because the code only checked for the base terraform componenttest/test-componentin all imports.After this fix, the code checks all imported files for the base terraform component and ALL base YAML components.