tools/lintroller/testdata/src/a/bad_test.go (3)

37-37: Add period to inline comment.

The inline comment doesn't end with a period, which violates the godot linter requirement.

As per coding guidelines.

Apply this diff:

-		os.Setenv("PATH", orig) // OK: os.Setenv is allowed in defer blocks
+		os.Setenv("PATH", orig) // OK: os.Setenv is allowed in defer blocks.

---

52-52: Add period to inline comment.

The inline comment doesn't end with a period, which violates the godot linter requirement.

As per coding guidelines.

Apply this diff:

-	tempDir, _ := os.MkdirTemp("", "bench-*") // OK: os.MkdirTemp is allowed in benchmarks
+	tempDir, _ := os.MkdirTemp("", "bench-*") // OK: os.MkdirTemp is allowed in benchmarks.

---

58-58: Add period to inline comment.

The inline comment doesn't end with a period, which violates the godot linter requirement.

As per coding guidelines.

Apply this diff:

-	os.Setenv("PATH", "/bench/path") // OK: os.Setenv is allowed in benchmarks
+	os.Setenv("PATH", "/bench/path") // OK: os.Setenv is allowed in benchmarks.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: aknysh
PR: cloudposse/atmos#1352
File: pkg/store/artifactory_store_test.go:108-113
Timestamp: 2025-08-15T14:43:41.030Z
Learning: In test files for the atmos project, it's acceptable to ignore errors from os.Setenv/Unsetenv operations during test environment setup and teardown, as these are controlled test scenarios.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

.github/workflows/codeql.yml (1)

104-112: Pin the action’s version to match the built binary.

You install/build v2.5.0 but set the action to “latest”. Pin it to the same version to avoid drift.

-          version: latest
+          version: v2.5.0
           install-mode: none  # Use the custom binary we built above
           only-new-issues: true
           args: >
             --out-format=sarif:golangci-lint.sarif
             --issues-exit-code=0

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-09-23T02:30:42.362Z
Learning: Applies to .golangci.yml : Configure golangci-lint with gofmt, goimports, govet, staticcheck, errcheck, ineffassign, misspell, unused, revive, gocritic enabled

tools/lintroller/README.md (3)

185-194: Pin plugin sources for reproducible builds

The .custom-gcl.yml example is clear. To avoid surprises, consider pinning plugins by tag/commit (module@vX.Y.Z) or via a replace directive, even when using local path.

---

247-266: Add SARIF upload step and avoid sudo cp in CI

• Add an upload step so results reach GitHub Security.
• Prefer placing ./custom-gcl earlier in PATH instead of sudo copying over system golangci-lint.

Apply these tweaks:

- - name: Build custom golangci-lint with plugins
-   run: |
-     golangci-lint custom
-     sudo cp ./custom-gcl /usr/local/bin/golangci-lint
+ - name: Build custom golangci-lint with plugins
+   run: |
+     golangci-lint custom
+     echo "$PWD" >> $GITHUB_PATH
+
+ - name: Verify custom binary
+   run: ./custom-gcl version

- - name: Run golangci-lint with plugins
+ - name: Run golangci-lint with plugins
    uses: golangci/golangci-lint-action@v8
    with:
-     install-mode: none  # Use our custom binary instead of action's binary
-     args: --out-format=sarif:golangci-lint.sarif
+     install-mode: none  # Use our custom binary instead of action's binary
+     args: --out-format=sarif:golangci-lint.sarif --timeout=5m
+     version: none       # Ensure action doesn't install its own binary

+ - name: Upload SARIF to GitHub Security
+   uses: github/codeql-action/upload-sarif@v3
+   with:
+     sarif_file: golangci-lint.sarif

---

267-272: Name consistency: “Lint Roller” vs “Lintroller”

Use one style throughout (prefer “Lint Roller” for prose, “lintroller” for the linter ID).

Apply:

-Benefits:
-- ✅ Lintroller findings appear in GitHub Security tab via SARIF
-- ✅ Inline PR annotations for violations
-- ✅ Unified linting output (standard + custom linters)
-- ✅ Supports `//nolint:lintroller` comments
+Benefits:
+- ✅ Lint Roller findings appear in GitHub Security tab via SARIF
+- ✅ Inline PR annotations for violations
+- ✅ Unified linting output (standard + custom linters)
+- ✅ Supports `//nolint:lintroller` comments

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-09-23T02:30:42.362Z
Learning: Applies to .golangci.yml : Configure golangci-lint with gofmt, goimports, govet, staticcheck, errcheck, ineffassign, misspell, unused, revive, gocritic enabled

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-09-23T02:30:42.362Z
Learning: Applies to **/*.go : All code must pass golangci-lint checks

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-09-23T02:30:42.362Z
Learning: Before submitting PRs, ensure tests pass, coverage targets met, run golangci-lint, and update documentation

.github/workflows/codeql.yml (1)

93-118: Comments are helpful but overly verbose.

The inline documentation is thorough, but the sheer volume makes the workflow harder to scan. Consider condensing these into a shorter explanation with a link to external docs if needed.

tools/lintroller/testdata/src/a/bad_test.go (1)

51-54: Consider handling the error even in benchmark test data.

Line 52 ignores the error from os.MkdirTemp. While this is test data meant to verify the linter detects os.MkdirTemp usage, ignoring errors—even in benchmarks—can make the test data misleading. Consider at least a panic or b.Fatal if the goal is to show that os.MkdirTemp itself (not error handling) is the issue.

Example:

 func BenchmarkGoodMkdirTemp(b *testing.B) {
-	tempDir, _ := os.MkdirTemp("", "bench-*") // OK: os.MkdirTemp is allowed in benchmarks.
+	tempDir, err := os.MkdirTemp("", "bench-*") // OK: os.MkdirTemp is allowed in benchmarks.
+	if err != nil {
+		b.Fatal(err)
+	}
 	defer os.RemoveAll(tempDir)
 }

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-09-23T02:30:42.362Z
Learning: Applies to .golangci.yml : Configure golangci-lint with gofmt, goimports, govet, staticcheck, errcheck, ineffassign, misspell, unused, revive, gocritic enabled

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-09-23T02:30:42.362Z
Learning: Applies to **/*.go : All code must pass golangci-lint checks

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-09-23T02:30:42.362Z
Learning: Before submitting PRs, ensure tests pass, coverage targets met, run golangci-lint, and update documentation

Learnt from: aknysh
PR: cloudposse/atmos#1352
File: pkg/store/artifactory_store_test.go:108-113
Timestamp: 2025-08-15T14:43:41.030Z
Learning: In test files for the atmos project, it's acceptable to ignore errors from os.Setenv/Unsetenv operations during test environment setup and teardown, as these are controlled test scenarios.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-09-23T02:30:42.362Z
Learning: Applies to .golangci.yml : Configure golangci-lint with gofmt, goimports, govet, staticcheck, errcheck, ineffassign, misspell, unused, revive, gocritic enabled

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-09-23T02:30:42.362Z
Learning: Applies to **/*.go : All code must pass golangci-lint checks

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-09-23T02:30:42.362Z
Learning: Applies to .golangci.yml : Configure golangci-lint with gofmt, goimports, govet, staticcheck, errcheck, ineffassign, misspell, unused, revive, gocritic enabled

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-09-23T02:30:42.362Z
Learning: Applies to .golangci.yml : Configure golangci-lint with gofmt, goimports, govet, staticcheck, errcheck, ineffassign, misspell, unused, revive, gocritic enabled

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-09-23T02:30:42.362Z
Learning: Applies to **/*.go : All code must pass golangci-lint checks

Learnt from: CR
PR: cloudposse/atmos#0
File: CLAUDE.md:0-0
Timestamp: 2025-10-16T15:18:00.319Z
Learning: Applies to **/*.go : Ensure Atmos remains portable across Linux, macOS, and Windows; use filepath.Join, os.PathSeparator, and build constraints when necessary.

.github/workflows/codeql.yml (1)

144-156: Job won't fail when lint violations are found—enforce via re-fail step.

The continue-on-error: true on line 145 suppresses the lint step's exit code, so the job succeeds even when violations exist. The comments state "proper enforcement," but currently violations are uploaded to SARIF without blocking the PR. Add a step to re-fail after SARIF upload:

      - name: Run golangci-lint with lintroller plugin
        continue-on-error: true
+       id: lint
        run: |
          # Run the custom binary directly instead of via the action
          # The action was finding the system binary even with install-mode: none
          golangci-lint run \
            --new-from-rev=origin/${{ github.base_ref }} \
            --output.sarif.path=golangci-lint.sarif \
            --issues-exit-code=1 \
            --new=false

      - name: Upload filtered SARIF results
         if: always()
         uses: github/codeql-action/upload-sarif@v3
         with:
           sarif_file: golangci-lint.sarif
+
+      - name: Fail if lint violations found
+        if: failure() && steps.lint.outcome == 'failure'
+        run: exit 1

(The flags --new-from-rev and --new=false work together correctly; --new-from-rev enables diff-based checking independently and --new=false doesn't override it.)

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-09-23T02:30:42.362Z
Learning: Applies to .golangci.yml : Configure golangci-lint with gofmt, goimports, govet, staticcheck, errcheck, ineffassign, misspell, unused, revive, gocritic enabled

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-09-23T02:30:42.362Z
Learning: Applies to **/*.go : All code must pass golangci-lint checks

.github/workflows/codeql.yml (1)

145-160: Add a step to verify the custom binary is being used by the action.

Currently, after replacing the binary, there's no confirmation that the action actually uses the custom binary. Add a verification step (e.g., which golangci-lint && golangci-lint --version) to detect if binary setup failed silently:

       chmod +x ~/go/bin/golangci-lint
       golangci-lint --version

+      - name: Verify custom golangci-lint is in PATH
+        run: |
+          which golangci-lint
+          golangci-lint --version
+          # Confirm lintroller is included (if possible)
+          golangci-lint help | grep -q "lintroller" || echo "WARNING: lintroller may not be compiled in"

       - name: Run golangci-lint with lintroller plugin
         continue-on-error: true

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-09-23T02:30:42.362Z
Learning: Applies to .golangci.yml : Configure golangci-lint with gofmt, goimports, govet, staticcheck, errcheck, ineffassign, misspell, unused, revive, gocritic enabled

pkg/config/load_test.go (1)

14-22: Simplify by removing the no-op cleanup closure.

Since t.TempDir() handles cleanup automatically, returning and deferring a no-op cleanup function adds unnecessary complexity. Similarly, t.Setenv auto-cleans, so the pattern throughout these tests doesn't need manual cleanup.

Apply this diff to simplify:

-func setupTestFiles(t *testing.T) (string, func()) {
+func setupTestFiles(t *testing.T) string {
 	tempDir := t.TempDir()
-
-	cleanup := func() {
-		// t.TempDir() handles cleanup automatically
-	}
-
-	return tempDir, cleanup
+	return tempDir
 }

Then update the single call site at line 78:

-		tempDir, cleanup := setupTestFiles(t)
-		defer cleanup()
+		tempDir := setupTestFiles(t)

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-09-23T02:30:42.362Z
Learning: Applies to .golangci.yml : Configure golangci-lint with gofmt, goimports, govet, staticcheck, errcheck, ineffassign, misspell, unused, revive, gocritic enabled

Learnt from: samtholiya
PR: cloudposse/atmos#1255
File: cmd/describe_affected_test.go:15-15
Timestamp: 2025-05-23T19:51:47.091Z
Learning: The atmos codebase has a custom extension to *testing.T that provides a Chdir method, allowing test functions to call t.Chdir() to change working directories during tests. This is used consistently across test files in the codebase.

Learnt from: samtholiya
PR: cloudposse/atmos#1255
File: cmd/describe_affected_test.go:15-15
Timestamp: 2025-05-23T19:51:47.091Z
Learning: In the atmos codebase, t.Chdir() is a valid method that can be called on *testing.T objects. This functionality is implemented through custom testing framework extensions and is used consistently throughout the test suite for changing working directories during tests.

Learnt from: samtholiya
PR: cloudposse/atmos#1255
File: cmd/describe_affected_test.go:15-15
Timestamp: 2025-05-23T19:51:47.091Z
Learning: In the atmos codebase, t.Chdir() is a valid method call on *testing.T objects and works correctly for changing directories in tests. This is implemented through custom testing framework extensions and is used consistently throughout the test suite.

Learnt from: aknysh
PR: cloudposse/atmos#1352
File: pkg/store/artifactory_store_test.go:108-113
Timestamp: 2025-08-15T14:43:41.030Z
Learning: In test files for the atmos project, it's acceptable to ignore errors from os.Setenv/Unsetenv operations during test environment setup and teardown, as these are controlled test scenarios.

Learnt from: samtholiya
PR: cloudposse/atmos#1255
File: cmd/describe_affected_test.go:15-15
Timestamp: 2025-05-23T19:51:47.091Z
Learning: In the atmos codebase, t.Chdir() is a valid method call on *testing.T objects and works correctly for changing directories in tests.