Fix bug related to loading and merging atmos configurations files#1175
Fix bug related to loading and merging atmos configurations files#1175
Conversation
📝 WalkthroughWalkthroughThe Changes
Suggested labels
Suggested reviewers
Possibly related PRs
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
🔇 Additional comments (3)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pkg/config/load.go (1)
203-212: Isolating config loading in a temporary Viper improves reliability.
This approach helps ensure the main instance is unaffected by any failed read. If future requirements expand to support other file types, consider dynamically detecting file formats rather than hardcoding "yaml".
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pkg/config/load.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: [mock-windows] tests/fixtures/scenarios/complete
- GitHub Check: [mock-windows] examples/demo-vendoring
- GitHub Check: [localstack] demo-localstack
- GitHub Check: Acceptance Tests (macos-latest, macos)
- GitHub Check: Acceptance Tests (windows-latest, windows)
- GitHub Check: Acceptance Tests (ubuntu-latest, linux)
- GitHub Check: Lint (golangci)
- GitHub Check: Analyze (go)
- GitHub Check: Summary
🔇 Additional comments (2)
pkg/config/load.go (2)
214-214: Assigning the config file to the main Viper instance is clear and consistent.
This ensures subsequent merges target the correct path.
219-219: Reading the configuration file content here is sensible.
It cleanly feeds into the YAML preprocessing logic.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1175 +/- ##
==========================================
+ Coverage 28.25% 28.29% +0.03%
==========================================
Files 182 182
Lines 21274 21284 +10
==========================================
+ Hits 6012 6022 +10
Misses 14312 14312
Partials 950 950
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What
Why
references
Summary by CodeRabbit