Automate Nightly Builds as Pre-release Candidates#1114
Conversation
|
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
📝 WalkthroughWalkthroughThe changes modify the GitHub Actions workflows by introducing conditional execution for jobs in Changes
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/build.yml (2)
22-22: Pre-release Conditional Logic & Trailing Space Cleanup.
The new condition for thereleasejob correctly checks that the release is not a pre release, which aligns well with the PR’s objectives. However, static analysis detected trailing spaces at the end of this line. Please remove these spaces to comply with YAML formatting standards.- if: ${{ github.event.release.prerelease == false }} + if: ${{ github.event.release.prerelease == false }}🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 22-22: trailing spaces
(trailing-spaces)
27-27: Conditional Check for Homebrew Job & Formatting.
The update on thehomebrewjob properly prevents its execution during pre releases. Similar to thereleasejob, there are trailing spaces at the end of this line. Cleaning these up will improve consistency and comply with YAMLlint requirements.- if: ${{ github.event.release.prerelease == false }} + if: ${{ github.event.release.prerelease == false }}🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 27-27: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/build.yml
[error] 22-22: trailing spaces
(trailing-spaces)
[error] 27-27: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Build (windows-latest, windows)
- GitHub Check: Summary
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1114 +/- ##
=======================================
Coverage 17.29% 17.29%
=======================================
Files 169 169
Lines 18747 18747
=======================================
Hits 3242 3242
Misses 14908 14908
Partials 597 597
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <erik@cloudposse.com>
|
These changes were released in v1.165.2. |
what
why
Summary by CodeRabbit