Skip to content

Fix distributed downstream tests#518

Merged
ogrisel merged 3 commits intocloudpipe:masterfrom
jrbourbeau:distributed-fixup
Oct 11, 2023
Merged

Fix distributed downstream tests#518
ogrisel merged 3 commits intocloudpipe:masterfrom
jrbourbeau:distributed-fixup

Conversation

@jrbourbeau
Copy link
Copy Markdown
Member

Adding pytest-cov as a testing dependency unblocks the distributed CI tests. Now let's see if they actually pass...

@jrbourbeau jrbourbeau added the ci distributed Signal the CI to run the test suite of distributed (downstream project of cloudpickle) label Oct 10, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ab32ba5) 83.44% compared to head (bc5189a) 83.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #518   +/-   ##
=======================================
  Coverage   83.44%   83.44%           
=======================================
  Files           4        4           
  Lines         725      725           
  Branches      157      157           
=======================================
  Hits          605      605           
  Misses         95       95           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrbourbeau
Copy link
Copy Markdown
Member Author

Okay, so the only failure is distributed/tests/test_scheduler.py::test_decide_worker_coschedule_order_neighbors which is a known issue being resolved upstream (xref dask/distributed#8255)

@jrbourbeau jrbourbeau changed the title [WIP] Unblock distributed downstream tests Fix distributed downstream tests Oct 10, 2023
@jrbourbeau jrbourbeau mentioned this pull request Oct 11, 2023
@ogrisel
Copy link
Copy Markdown
Contributor

ogrisel commented Oct 11, 2023

Thanks for the fix!

@ogrisel ogrisel merged commit 604122c into cloudpipe:master Oct 11, 2023
@jrbourbeau jrbourbeau deleted the distributed-fixup branch October 11, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci distributed Signal the CI to run the test suite of distributed (downstream project of cloudpickle)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants