Dont pickle abc caches of instances of abc.ABCMeta subclasses. #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@llllllllll if you want to take a look. |
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
===========================================
- Coverage 92.84% 78.86% -13.98%
===========================================
Files 2 2
Lines 852 861 +9
Branches 177 178 +1
===========================================
- Hits 791 679 -112
- Misses 37 143 +106
- Partials 24 39 +15
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
======================================
Coverage 92.9% 92.9%
======================================
Files 2 2
Lines 860 860
Branches 179 179
======================================
Hits 799 799
Misses 37 37
Partials 24 24Continue to review full report at Codecov.
|
ogrisel
approved these changes
Feb 10, 2020
Contributor
ogrisel
left a comment
There was a problem hiding this comment.
LGTM but the changelog need an update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #302
Don't pickle the
abccaches populated duringisinstance/issubclasschecks against instances ofabc.ABCMetasubclasses.