feat(restore): wait for all init containers before starting cluster restore#9026
Merged
feat(restore): wait for all init containers before starting cluster restore#9026
Conversation
Member
Author
|
/test limit=local |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/19030349214 |
Member
Author
|
/test limit=local |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/19030849418 |
Member
Author
|
/test limit=local |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/19031322675 |
mnencia
approved these changes
Nov 5, 2025
078f572 to
2a1f121
Compare
Member
|
/ok-to-merge tests are green |
2a1f121 to
c2b113e
Compare
jbattiato
approved these changes
Nov 12, 2025
…estore Previously, the cluster restore process immediately returned success without waiting for any init containers to complete. This meant restore operations from backup tools (Velero, Kasten, etc.) could start before the restore data was fully prepared. Now the restore process actively waits for all init containers to complete before proceeding. The implementation is tool-agnostic and correctly handles Kubernetes init container sidecars by ignoring those with RestartPolicy=Always. This ensures that any backup/restore solution using init containers will have sufficient time to prepare the cluster before the restore process proceeds. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
c2b113e to
8f84e82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the cluster restore process immediately returned success without waiting for any init containers to complete. This meant restore operations from backup tools could start before the restore data was fully prepared.
Now the restore process actively waits for all init containers to complete before proceeding. The implementation is tool-agnostic and correctly handles Kubernetes init container sidecars by ignoring those with RestartPolicy=Always.
This ensures that any backup/restore solution using init containers will have sufficient time to prepare the cluster before the restore process proceeds.
Closes #9025