Update <CldUploadButton> component#151
Closed
max-programming wants to merge 0 commit intocloudinary-community:mainfrom
Closed
Update <CldUploadButton> component#151max-programming wants to merge 0 commit intocloudinary-community:mainfrom
<CldUploadButton> component#151max-programming wants to merge 0 commit intocloudinary-community:mainfrom
Conversation
|
@max-programming is attempting to deploy a commit to the Cloudinary DevX Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
i appreciate you adding Sonner, great library, but generally i want to keep the examples as MVP as possible, avoiding dependencies where we can, i think in this example we can maintain just updating the page with state to show the image/url the rest looks good to me! |
Contributor
Author
|
@colbyfayock Done |
Collaborator
|
hey @max-programming im not sure whats going on but im getting some funky conflicts after merging in your other upload widget example, can you take al ook at this? idk if we need to just delete it and readd it or osmething |
02f1eb2 to
467a493
Compare
Contributor
Author
|
@colbyfayock I opened #160 with the changes now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the example for the
<CldUploadButton>component. The changes are as followsCldImageandCldVideoPlayerto display the uploaded media