Skip to content

Upgrade CldOgImage component#145

Merged
colbyfayock merged 12 commits intocloudinary-community:mainfrom
max-programming:feat/upgrade-cldogimage
Apr 5, 2024
Merged

Upgrade CldOgImage component#145
colbyfayock merged 12 commits intocloudinary-community:mainfrom
max-programming:feat/upgrade-cldogimage

Conversation

@max-programming
Copy link
Copy Markdown
Contributor

@max-programming max-programming commented Mar 30, 2024

Changes made are as follows:

  • Upgrade dependencies
  • Add Prettier and Tailwind CSS
  • Add an example for the app router
  • Better design than before
  • Use sample images that already come with a Cloudinary account

Screenshots

Website

image

This screenshot is only of the app router demo. The pages router (homepage) does not have the text with the description about the app router

Open Graph

image

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2024

@max-programming is attempting to deploy a commit to the Cloudinary DevX Team on Vercel.

A member of the Team first needs to authorize it.

Comment thread examples/nextjs-cldogimage/app/app/page.jsx Outdated
Comment thread examples/nextjs-cldogimage/app/app/page.jsx Outdated
Comment thread examples/nextjs-cldogimage/components/Header.jsx Outdated
Comment thread examples/nextjs-cldogimage/components/Footer.jsx
@colbyfayock
Copy link
Copy Markdown
Collaborator

added a few comments otherwise looking good!

…n app router and pages router. Change alt text
@max-programming
Copy link
Copy Markdown
Contributor Author

Changes made 🤝

@colbyfayock
Copy link
Copy Markdown
Collaborator

sorry to be a pain, im getting funky issues with the header link to github now
image

otherwise looks good

@max-programming
Copy link
Copy Markdown
Contributor Author

max-programming commented Apr 5, 2024

Made a little adjustment. Let me know if that fixes it up
I'm actually unable to reproduce this

@colbyfayock
Copy link
Copy Markdown
Collaborator

weird. not sure wht was going on but fixed it. merging in. thanks

@colbyfayock colbyfayock merged commit bfed98e into cloudinary-community:main Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants