Skip to content

Reject promise for error codes 400, 401, 404, 420 and 500 during file upload #32

@gauravhub

Description

@gauravhub

Inside handle_repsone method (file: lib/uploader.coffee), for HTTP error codes 400,401,404,420 and 500, promise is being resolved deferred.resolve(result) (line number: 178) with result object holding the error object. Instead, shouldn't the promise be rejected with preferably error object deferred.reject(result["error"]) or result object deferred.reject(result)?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions