migration to bitcoin 0.30 by vincenzopalazzo · Pull Request #145 · cloudhead/nakamoto

vincenzopalazzo · 2023-06-07T13:53:20Z

This is a WIP, so this patch will be out just for early review.

vladimirfomene · 2023-08-08T04:39:55Z

Hi @vincenzopalazzo ! I was wondering if you have been able to make progress with this PR locally. We will need it for BDK's integration with Nakamoto. If not, I'm willing to help if you don't have time to focus on it.

vincenzopalazzo · 2023-08-08T07:01:37Z

In reality, I was waiting bdk team to do this because I was blocked on my project for the same reason 😄 I did not finish this before because everyone was not upgrading to the new version of rust-bitcoin

So now that the bdk team has done it, I will finish the PR

vladimirfomene · 2023-08-08T08:33:49Z

In reality, I was waiting bdk team to do this because I was blocked on my project for the same reason 😄 I did not finish this before because everyone was not upgrading to the new version of rust-bitcoin

So now that the bdk team has done it, I will finish the PR

Thanks

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

vincenzopalazzo

Small self note that I need to look at

vincenzopalazzo · 2023-08-13T16:59:54Z

common/src/block/tree.rs


-        target = target.mul_u32(adjusted_timespan);
-        target = target / Target::from_u64(params.pow_target_timespan).unwrap();
+        target = target * adjusted_timespan;


looks like this is not correct, the target is a u256 so this will overflow.

Maybe rust-bitcoin should make available the same operation?

vincenzopalazzo · 2023-08-13T20:03:59Z

This is blocked by rust-bitcoin/rust-bitcoin#1993

vincenzopalazzo · 2023-08-13T20:18:22Z

chain/src/block/cache.rs

-        let mut best_work = Uint256::zero();
+        // FIXME: this need to be a Work by network? or the min is equal for
+        // every network?
+        let mut best_work = Work::MAINNET_MIN;


This should be general and not with mainet only

vincenzopalazzo · 2023-08-13T20:25:09Z

chain/src/block/cache/test.rs


-use nakamoto_common::bitcoin;
-use nakamoto_common::bitcoin::blockdata::block::BlockHeader;
+use nakamoto_common::bitcoin::{self, CompactTarget};


split in two line

vincenzopalazzo · 2023-08-13T20:35:35Z

p2p/src/fsm.rs

-            return self.disconnect(addr, DisconnectReason::PeerMagic(msg.magic));
+            return self.disconnect(
+                addr,
+                DisconnectReason::PeerMagic(u32::from_be_bytes(msg.magic.to_bytes())),


Mh maybe it is possible to better than this at the API level

vincenzopalazzo · 2023-08-13T20:35:54Z

p2p/src/fsm/cbfmgr/rescan.rs

 use std::rc::Rc;

-use nakamoto_common::bitcoin::util::bip158;
+use nakamoto_common::bitcoin::{bip158, ScriptBuf};


this need to be splitted

vincenzopalazzo · 2023-08-13T20:36:31Z

p2p/src/fsm/fees.rs

        let fee = received - sent;
        let weight = tx.weight();
-        let rate = fee as f64 / (weight as f64 / WITNESS_SCALE_FACTOR as f64);
+        let rate = fee as f64 / (weight.to_wu() as f64 / WITNESS_SCALE_FACTOR as f64);


make a double check, what is to_wu

vincenzopalazzo · 2023-08-13T20:36:48Z

p2p/src/fsm/output.rs

 //! with specific capabilities, eg. peer disconnection, message sending etc. to
 //! communicate with the network.
 use log::*;
+use nakamoto_common::bitcoin::network::Magic;


fix the import order

vincenzopalazzo · 2023-08-13T20:37:20Z

p2p/src/fsm/tests.rs

+use std::str::FromStr;
 use std::sync::Arc;

 use log::*;


fix the import order

vincenzopalazzo · 2023-08-13T20:39:13Z

chain/src/block/cache/test.rs

            height,
            BlockHeader {
-                version: 1,
+                version: Version::from_consensus(1),


Suggested change

version: Version::from_consensus(1),

version: Version::ONE,

vincenzopalazzo

This is my self review to see the blocking step to get this PR merged and also to see if I introduce regression

vladimirfomene · 2023-09-22T10:04:08Z

Hi @vincenzopalazzo ! I know you are very busy doing other important work but I just wanted to check if there has been any progress. We are still waiting on it to implement BDK's CBF syncing feature.

cloudhead · 2023-10-18T22:37:39Z

Still waiting on rust-bitcoin/rust-bitcoin#2090 afaict

vincenzopalazzo · 2024-05-18T08:05:21Z

Ok finally this is merged rust-bitcoin/rust-bitcoin#2740

Waiting so see what will be the next release where this will be merged and I will finish this PR or maybe open a new one

vincenzopalazzo mentioned this pull request Aug 7, 2023

Add Compact Block Filters Syncing bitcoindevkit/bdk#1055

Closed

5 tasks

migration to bitcoin 0.30

7dce803

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

vincenzopalazzo force-pushed the macros/bitcoin_upgrade branch from 3a67b57 to 7dce803 Compare August 13, 2023 12:51

vincenzopalazzo added 2 commits August 13, 2023 16:23

fixup! migration to bitcoin 0.30

117d6ba

fixup! fixup! migration to bitcoin 0.30

32e376c

vincenzopalazzo commented Aug 13, 2023

View reviewed changes

fixup! fixup! migration to bitcoin 0.30

907be90

vincenzopalazzo mentioned this pull request Aug 13, 2023

Adds possibility to make math operations on the Target type rust-bitcoin/rust-bitcoin#1993

Closed

vincenzopalazzo commented Aug 13, 2023

View reviewed changes

p2p/src/fsm/tests.rs

use std::str::FromStr;

use std::sync::Arc;

use log::*;

Copy link
Copy Markdown

Collaborator Author

vincenzopalazzo Aug 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the import order

vincenzopalazzo commented Aug 13, 2023

View reviewed changes

fixup! migration to bitcoin 0.30

47d3c37

ValuedMammal mentioned this pull request Mar 10, 2024

Implement bdk_nakamoto chain-source crate bitcoindevkit/bdk#679

Closed

Uh oh!

Conversation

vincenzopalazzo commented Jun 7, 2023

Uh oh!

vladimirfomene commented Aug 8, 2023

Uh oh!

vincenzopalazzo commented Aug 8, 2023

Uh oh!

vladimirfomene commented Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vincenzopalazzo left a comment

Choose a reason for hiding this comment

Uh oh!

vincenzopalazzo Aug 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vincenzopalazzo commented Aug 13, 2023

Uh oh!

vincenzopalazzo Aug 13, 2023

Choose a reason for hiding this comment

Uh oh!

vincenzopalazzo Aug 13, 2023

Choose a reason for hiding this comment

Uh oh!

vincenzopalazzo Aug 13, 2023

Choose a reason for hiding this comment

Uh oh!

vincenzopalazzo Aug 13, 2023

Choose a reason for hiding this comment

Uh oh!

vincenzopalazzo Aug 13, 2023

Choose a reason for hiding this comment

Uh oh!

vincenzopalazzo Aug 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vincenzopalazzo Aug 13, 2023

Choose a reason for hiding this comment

Uh oh!

vincenzopalazzo Aug 13, 2023

Choose a reason for hiding this comment

Uh oh!

vincenzopalazzo left a comment

Choose a reason for hiding this comment

Uh oh!

vladimirfomene commented Sep 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloudhead commented Oct 18, 2023

Uh oh!

vincenzopalazzo commented May 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vladimirfomene commented Aug 8, 2023 •

edited

Loading

vincenzopalazzo Aug 13, 2023 •

edited

Loading

vincenzopalazzo Aug 13, 2023 •

edited

Loading

vladimirfomene commented Sep 22, 2023 •

edited

Loading