Fix failing helm upgrade #1325
Fix failing helm upgrade #1325manno merged 1 commit intocloudfoundry-incubator:masterfrom HCL-Cloud-Native-Labs:master
Conversation
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/178543209 The labels on this github issue will be updated when the story is started. |
|
|
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/178543556 The labels on this github issue will be updated when the story is started. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/178543719 The labels on this github issue will be updated when the story is started. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/178543796 The labels on this github issue will be updated when the story is started. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/178543847 The labels on this github issue will be updated when the story is started. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/178543877 The labels on this github issue will be updated when the story is started. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/178552384 The labels on this github issue will be updated when the story is started. |
| "helm.sh/hook-delete-policy": before-hook-creation | ||
| {{- if $.Values.global.image.credentials }} | ||
| imagePullSecrets: | ||
| - name: {{$hook}}-pull-secret |
There was a problem hiding this comment.
I don't think you really need to define additional secrets, you can just reference the operator service account secret:
- name: {{ template "cf-operator.serviceAccountName" . }}-pull-secret
I don't care too much, but generally dislike redundant config. Just makes debugging harder than it needs to be. :)
But otherwise the change looks fine. I'll let @manno decide if he is going to accept it as-is, or wants any changes.
|
@jbuns I released https://github.com/cloudfoundry-incubator/quarks-operator/releases/tag/v7.2.7 with the fix |
|
thanks, @manno! |
Motivation and Context
Fix failing helm upgrade when using
.Values.global.image.credentials.Fixes #1311
Checklist:
Check item if necessary.