This repository was archived by the owner on Oct 22, 2021. It is now read-only.
Remove startup-ordinal, use pre-generated job instances (affects bootstrap, etc)#1288
Merged
Remove startup-ordinal, use pre-generated job instances (affects bootstrap, etc)#1288
Conversation
0ab09b6 to
897c89f
Compare
897c89f to
edc80f3
Compare
template-render uses the pre-generated jobInstances, like the instance-group resolver does. * Removed startup-ordinal * Add pod ordinal to trender args * Also move calculations into RenderJobTemplates * Add docs on args and failing test * Fix for azIndex=1 with no AZs in manifest * Use temp dir for unit tests, avoids conflicts when running in parallel
It's still necessary for some tests, so they wait the right amount of time.
ffbc331 to
f3b95f9
Compare
The new quarks-statefulset-name label was used for setting the startup-ordinal. However startup-ordinal was dropped. Renaming the labels produced failures, when updating multi-az deployments, as the sts selector has to match the spec.template.labels, but can't be updated once created.
Didn't report right line numbers.
648459f to
59c7138
Compare
Also fixes for building with locally modified quarks-* operators.
Member
Author
|
Failed, becaued this version can't upgrade deployments from quarks-operator 7.1.3, which introduced the statefulset-name label. (statefulset's label selector can't be updated after creation). Adding another migration script. |
6e0ffa4 to
0e91e81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#176906742