Conversation
Contributor
|
the github action test is failing due to the fact that it tries to download big files which results in out of disk space errors. |
ramonskie
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the OverrideYml integration test to work with CF API v3.
Why
After migrating to switchblade with CF API v3 support, the OverrideYml test was failing because staging logs are no longer captured in the
Deploy.Execute()logs buffer when staging fails.In v2, the logs buffer contained both setup and staging output. In v3, when staging fails:
How
Modified the test to fetch staging logs using
cf logs --recent:Target correct org/space: Switchblade creates a dedicated org and space with the same name as the app. The test now targets this space before fetching logs.
Direct log verification: Replaced
Eventually(logs).Should(SatisfyAll(...))with directExpect()assertions on the fetched logs.