Skip to content

Conversation

@bruce-ricard
Copy link
Contributor

No description provided.

@bruce-ricard
Copy link
Contributor Author

cc: @rizwanreza

@rkoster rkoster self-requested a review July 7, 2022 15:12
@bruce-ricard
Copy link
Contributor Author

Some check is failing:

{
"component": "peribolos",
"file": "k8s.io/test-infra/prow/cmd/peribolos/main.go:188",
"func": "main.main",
"level": "fatal",
"msg": "Configuration failed: failed to list cloudfoundry invitations: return code not 2XX: 401 Unauthorized",
"severity": "fatal",
"time": "2022-07-07T14:40:48Z"
}

Do I need to do something about that?

@stephanme
Copy link
Member

Strange, the same operation (list cloudfoundry invitations) succeeds in workflow Sync Github Organization Settings and other PRs validate as well like #336.

I retriggered the validation but it failed again. No real idea at the moment.
@rkoster: Did you see such errors before?

I suggest to go on with the role change process (you need one more +1 by a WG area approver) and then merge even if the check still fails.

@stephanme
Copy link
Member

The permissions of the github token used by the workflow are different (too low) when triggered by a PR from a fork (in contrast to a PR triggered from a branch of the community repo). This difference can be seen in the job logs under "Set up job" of the github action run.

There is a lot of text to read and understand: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#modifying-the-permissions-for-the-github_token

@emalm
Copy link
Contributor

emalm commented Jul 12, 2022

@peterhaochen47 Could you please approve adding @bruce-ricard as an approver in the CredHub and UAA areas? You're the only approver in both areas. Thanks!

@rkoster rkoster merged commit d26eac1 into cloudfoundry:main Jul 12, 2022
@bruce-ricard
Copy link
Contributor Author

Thank you folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants