Generate github teams according to RFC-0005 #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stephanme
commented
Jun 15, 2022
- teams for WG, WG areas, WG leads and WG bots
- added empty bot user list to all WG yamls
- enabled only for ARD and FI WGs as pilots
- teams for WG, WG areas, WG leads and WG bots - added empty bot user list to all WG yamls - enabled only for ARD and FI WGs as pilots
rkoster
requested changes
Jun 15, 2022
Contributor
rkoster
left a comment
There was a problem hiding this comment.
How will this script deal with repos outside the cloudfoundry org?
Co-authored-by: Ruben Koster <rubenk@vmware.com>
Ignore all repos from other github orgs listed in WG yaml. E.g. FI WG. Fixed bot users in FI WG as all github users have name and github id WG yaml (also bots).
TOC.md and WG md files which contain yaml blocks processed by org-management.py
jochenehret
approved these changes
Jun 21, 2022
rkoster
approved these changes
Jun 21, 2022
Contributor
rkoster
left a comment
There was a problem hiding this comment.
Since it filters for repo's in the cloudfoundry org all my concerns are addressed.
| maintainers = {u["github"] for u in wg["execution_leads"]} | ||
| maintainers |= {u["github"] for u in wg["technical_leads"]} | ||
| approvers = {u["github"] for a in wg["areas"] for u in a["approvers"]} | ||
| repositories = {r for a in wg["areas"] for r in a["repositories"] if r.startswith("cloudfoundry/")} |
Contributor
There was a problem hiding this comment.
We will have to rework this line later when we onboard other orgs into the automation but for now it should be fine.
LeePorte
approved these changes
Jun 21, 2022
emalm
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.