Add support for space-supporter role for set-space-role and unset-space-role #2176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unset-space-role This also makes both commands case-insensitive for all roles Still need to update help text, will ask in PR thread for requested help text #2175
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/178832672 The labels on this github issue will be updated when the story is started. |
Contributor
Author
|
@monamohebbi I have requested your review on this PR, once that's done it should be good to merge! |
monamohebbi
suggested changes
Jul 14, 2021
Contributor
monamohebbi
left a comment
There was a problem hiding this comment.
Looks good! I'm happy with the help text you have and don't think we should get to deep into bikeshedding, but let me know your thoughts on my suggestions. But could you update the test for whatever text you end up using?
Co-authored-by: Juan Diego Gonzalez <gojuan@vmware.com>
a-b
reviewed
Jul 16, 2021
| func convertSpaceRoleType(givenRole flag.SpaceRole) (constant.RoleType, error) { | ||
| switch givenRole.Role { | ||
| case "SpaceAuditor": | ||
| switch strings.ToLower(givenRole.Role) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR modify CLI v6 or v7?
v8!
Description of the Change
Adds support for space-supporter role on set-space-role and unset-space-role, it also makes role entry for these commands both case insensitive.
Help text needs to be modified, will ask in comments of this PR for what the folks working on RBAC want it to say
This will throw an error if you run it on any foundation not set up for space-supporter, which is most, so the command needs to be listed as beta and subject to change
Applicable Issues
#2175