Added new metric application_buildpack#126
Conversation
|
@adamspd just to ask one upfront question, are all those commits related to the new application_buildpack metric? If not it would be appreciated if they could spread across different PRs which would make it way easier to review them |
7230117 to
ab6ec61
Compare
|
Hi @benjaminguttmann-avtq, the commits were not related to a single metric but to the addition of 2 new metrics and the modification of a metric to add more information. I separated them into 3 pull requests as requested and yes, you're right, it will be easier later if we need to go back on one of them. |
gmllt
left a comment
There was a problem hiding this comment.
the fetchAndFilterDroplets() should be added to the workers execution pool using c.worker.PushIf("droplets", c.fetchDroplets, filters.Droplets)
|
@adamspd Please make sure to run |
Absolutely. |
42dd55d to
ce93f84
Compare
No description provided.