Inline some of bosh_common into bosh-director and prepare to extract
#2607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98cbb5a to
4b67c51
Compare
jpalermo
approved these changes
Mar 13, 2025
ystros
requested changes
Mar 13, 2025
Contributor
ystros
left a comment
There was a problem hiding this comment.
Looks good overall, though it seems like the CPIs are using the with_thread_name method / including the thread formatter file. Those would need to be updated before moving these.
This was previously consumed by the ruby bosh-agent
- remove unsued `BoshVersion` - rename module to `Bosh::Version`
- collapse `Loggin` and `RegexFilter` into `RegexLoggingFilter`
Signed-off-by: Joseph Palermo <joseph.palermo@broadcom.com>
This consolidates the file to the (internal) gem that uses it. No usage outside of `bosh` was found. Signed-off-by: Brian Upton <brian.upton@broadcom.com>
Signed-off-by: Brian Upton <brian.upton@broadcom.com>
386556b to
18fc6e7
Compare
Signed-off-by: Brian Upton <brian.upton@broadcom.com>
- Blobstore code module, and directory match Signed-off-by: Brian Upton <brian.upton@broadcom.com>
- collapse BaseClient and Client - Blobstores is responsible for creating specific client based on provider string Signed-off-by: Brian Upton <brian.upton@broadcom.com>
Signed-off-by: Brian Upton <brian.upton@broadcom.com>
bosh-directorbosh-director and cleanup modules
Signed-off-by: Brian Upton <brian.upton@broadcom.com>
Signed-off-by: Brian Upton <brian.upton@broadcom.com>
Signed-off-by: Brian Upton <brian.upton@broadcom.com>
Signed-off-by: Brian Upton <brian.upton@broadcom.com>
This work is in preparation for extracting this code to a separate repository since it is consumed by existing Ruby-based CPI's Signed-off-by: Brian Upton <brian.upton@broadcom.com>
bosh-director and cleanup modulesbosh-director and prepare to extract
jpalermo
approved these changes
Mar 14, 2025
fmoehler
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration spec run