faster crc32 of last <8 bytes on aarch64#9
Merged
vkrasnov merged 2 commits intocloudflare:gcc.amd64from Mar 18, 2018
landfillbaby:patch-1
Merged
faster crc32 of last <8 bytes on aarch64#9vkrasnov merged 2 commits intocloudflare:gcc.amd64from landfillbaby:patch-1
vkrasnov merged 2 commits intocloudflare:gcc.amd64from
landfillbaby:patch-1
Conversation
vkrasnov
suggested changes
Mar 18, 2018
crc32.c
Outdated
| crc = __crc32h(crc, *buf); | ||
| buf += 2; | ||
| } | ||
| if (len & 1) |
There was a problem hiding this comment.
I prefer a curly brace even on single line if :)
| crc = __crc32b(crc, *buf); | ||
| len--; | ||
| buf++; | ||
| if (len & 4) { |
There was a problem hiding this comment.
I now see that I used > in the loop, do you mind changing that to >= while you are at it?
vkrasnov
approved these changes
Mar 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of up to 7 individual bytes, process it as a word, a halfword, and a byte, and don't bother modifying the length counter