Handling undefined behavior in inffast_chunk#28
Merged
vkrasnov merged 1 commit intocloudflare:gcc.amd64from Mar 11, 2021
Merged
Handling undefined behavior in inffast_chunk#28vkrasnov merged 1 commit intocloudflare:gcc.amd64from
vkrasnov merged 1 commit intocloudflare:gcc.amd64from
Conversation
kornelski
reviewed
Mar 8, 2021
chunkcopy.h
Outdated
| return chunkcopy_core_safe(out, out - dist, len, limit); | ||
| #elif defined(__clang__) && !defined(__aarch64__) | ||
| /* Seems to perform better on 32bit (i.e. Android). */ | ||
| out = chunkcopy_core_safe(out, out - dist, len, limit); |
This ports a21a4e8 - "Handling undefined behavior in inffast_chunk" from the Chromium fork of zlib.
kornelski
approved these changes
Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports a21a4e8 - "Handling undefined behavior in inffast_chunk" from the Chromium fork of zlib by Adenilson Cavalcanti.
Link to patch being ported: https://chromium.googlesource.com/chromium/src/third_party/zlib/+/a21a4e8f27567b7c36f8274bf16ebca78b9a68ab%5E%21/#F0