fix: pages github deployment not triggering due to incorrect condition#344
Merged
Maximo-Guk merged 1 commit intocloudflare:mainfrom Jan 17, 2025
Merged
Conversation
Member
|
Thank you so much @alcpereira 👏! I went ahead and merged your changes. Just added a changeset, as well as modified the zod schema to remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After a few tries on different repos, and after a migration from
cloudflare/pages-actiontocloudflare/wrangler-action, the feature to add Github deployment and summary is not working.How to reproduce
Solution
Remove the conditional for
stagesas it's optional, not used in the action and currently preventing the Summary/Deployment to be generated.