Add GitHub deployments for parity with pages-action#325
Conversation
| url: z.string().optional(), | ||
| alias: z.string().optional(), | ||
| environment: z.enum(["production", "preview"]), | ||
| // optional, added in wrangler@TBD |
There was a problem hiding this comment.
Fill this out when there's been a new wrangler release that has the new fields we need for pages deploy detailed artifact
027ebd5 to
c7edd46
Compare
|
Do not merge until:
|
08b3cf6 to
ef98565
Compare
ef98565 to
ec43b38
Compare
|
I like having all the github logic into one file! |
684a156 to
7035fbc
Compare
|
Great to see this happening! I contributed some of the Pages action's features, and I have a few suggestions to avoid repeating some of its mistakes:
|
7035fbc to
e87d79c
Compare
…o be inside of github.ts
e87d79c to
cada7a6
Compare
Thanks a lot Aaron! I'm going to implement those changes in a separate PR as this PR is already getting to be pretty big! |
Addresses #301
This PR updates
wrangler-actiondependencies and adds@actions/github, so that we can create GitHub deployments, as well as job summaries when a user provides their GiHub token to the action config.Github deployments successfully tested here:

Job summary successfully tested here
