Use random UUID when creating wrangler artifacts output directory#318
Merged
Maximo-Guk merged 1 commit intomainfrom Nov 5, 2024
Merged
Conversation
jahands
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #317,
Problem: If a user runs wrangler-action multiple times we'll return the wrong
deployment-url, as we only return the first detailed deployment instance from the artifact file.Solution: Let's generate a new output directory with a randomUUID in the tmpDir, so that when the action is ran multiple times, we use the artifacts from that run, opposed to the artifacts from a previous run.
Tested here:
Returns correct output for first run
Returns correct output for second run