Unreverts #235 and don't automatically install wrangler when checking if it present#271
Unreverts #235 and don't automatically install wrangler when checking if it present#271Maximo-Guk merged 2 commits intomainfrom
Conversation
3c1c124 to
66efca2
Compare
|
@Maximo-Guk as I said in the comment in my PR, this approach is much better. I like how you solved it 🚀 |
AdiRishi
left a comment
There was a problem hiding this comment.
The only thing I'll add is that it might be good to add a test to ensure it installs the correct version of wrangler by default. Could be a test we add directly into deploy.yml, perhaps a simple exection of wrangler --version and checking that it returns the exected output.
I'd really like to add a test for this, however with the current state of tests in this repo #194 I'm going to hold off on that for now, and get this merged in relying on the manual tests. I'm hoping to work on converting most of the e2e |
See !239 for more context
This PR adds the
execNoInstallfield to packageManagers, so that when we're executing wrangler to check if it present with our various package manager configurations, we don't automatically install it, in the case that it isn't present.This was tested by running test-fixup-235 branch on the test-action branch of my demo-actions repo which contains hello-world workers applications for npm, pnpm, yarn and bun.
The successful pipeline where each package manager was tested https://github.com/Maximo-Guk/demo-actions/actions/runs/9533218220
cc @AdiRishi