Skip to content

testiing #255#256

Merged
RamIdeas merged 1 commit intomainfrom
legacy-concurrent-secret-uploads--draft-pr-for-tests
Apr 30, 2024
Merged

testiing #255#256
RamIdeas merged 1 commit intomainfrom
legacy-concurrent-secret-uploads--draft-pr-for-tests

Conversation

@RamIdeas
Copy link
Contributor

Draft PR to test #255

For up to date versions of wrangler, secrets are uploaded via the
'secret:bulk' command, which batches updates in a single API call.

For versions of wrangler without that capability, the action falls back
to the single 'secret put' command for each secret. It races all these
with a Promise.all()

Unfortunately, the single secret API cannot handle concurrency - at
best, these calls have to wait on one another, holding requests open
all the while. Often it times out and errors.

This fixes the legacy secret upload errors by making these calls
serially instead of concurrently.
@RamIdeas RamIdeas merged commit b05934f into main Apr 30, 2024
@RamIdeas RamIdeas deleted the legacy-concurrent-secret-uploads--draft-pr-for-tests branch April 30, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants