Does this actually resolve the error surfacing? I have a feeling that Wrangler is swallowing the error before it even gets to the wrangler-action.

Does this actually resolve the error surfacing? I have a feeling that Wrangler is swallowing the error before it even gets to the wrangler-action.

You're right in the sense that if wrangler cli itself is swallowing the error, this won't help.
However if that's not the case, at the very least this will log what we get back from the CLI output. Right now, even that error is swallowed and we just throw a generic Failed to upload secrets. error.

I think in this case the error will be swallowed by @actions/exec, which will throw an error like The process npx failed with exit code 1. We need to add listeners to capture output from the running command as described here:
https://github.com/actions/toolkit/blob/main/packages/exec/README.md#outputoptions

I think in this case the error will be swallowed by @actions/exec, which will throw an error like The process npx failed with exit code 1. We need to add listeners to capture output from the running command as described here: https://github.com/actions/toolkit/blob/main/packages/exec/README.md#outputoptions

Oh I see! Thank you, was not aware of this. I'll update the PR

Sorry, I got mixed up. Adding listeners to capture output from exec() shouldn't be necessary to pipe the results to stdout/stderr of the parent process, since that's already the default behavior. I suspect the error output is indeed being swallowed by wrangler itself.

Thanks again for the CR, definitely learned a few things about exec and it's output. If you'd like I can replace exec with getExecOutput and we can add stdout/stderr to the debug log as well.