Skip to content

Additional Error Handling#141

Merged
JacobMGEvans merged 2 commits intomainfrom
jacobmgevans/add-more-error-handling
Aug 10, 2023
Merged

Additional Error Handling#141
JacobMGEvans merged 2 commits intomainfrom
jacobmgevans/add-more-error-handling

Conversation

@JacobMGEvans
Copy link
Contributor

@JacobMGEvans JacobMGEvans commented Aug 10, 2023

Previously, we prevented any error logs from propagating too far to prevent leaking of any potentially sensitive information. However, this made it difficult for developers to debug their code.

In this release, we have updated our error handling to allow for more error messaging from pre/post and custom commands. We still discourage the use of these commands for secrets or other sensitive information, but we believe this change will make it easier for developers to debug their code.

Example of output in act local run:

[...wrangler_action_self_testing]     ::group::🚀 Executing Wrangler Commands
[...wrangler_action_self_testing]     ::error:: [ERROR] Unknown arguments: dry-run, dryRun, asdf, deploy%0A%0A%0A
[...wrangler_action_self_testing]     ::endgroup::

Relates to #137

Previously, we prevented any error logs from propagating too far to prevent leaking of any potentially sensitive information. However, this made it difficult for developers to debug their code.

In this release, we have updated our error handling to allow for more error messaging from pre/post and custom commands. We still discourage the use of these commands for secrets or other sensitive information, but we believe this change will make it easier for developers to debug their code.

Relates to #137
@JacobMGEvans JacobMGEvans requested a review from a team as a code owner August 10, 2023 15:12
@JacobMGEvans JacobMGEvans requested a review from 1000hz August 10, 2023 15:50
@JacobMGEvans JacobMGEvans force-pushed the jacobmgevans/add-more-error-handling branch 2 times, most recently from 1254f46 to 4198284 Compare August 10, 2023 15:52
@JacobMGEvans JacobMGEvans force-pushed the jacobmgevans/add-more-error-handling branch 5 times, most recently from 80204c9 to e7c823f Compare August 10, 2023 18:49
Co-authored-by: Cina Saffary <itscina@gmail.com>
@JacobMGEvans JacobMGEvans force-pushed the jacobmgevans/add-more-error-handling branch from e7c823f to 88466ea Compare August 10, 2023 19:51
@JacobMGEvans JacobMGEvans merged commit bb0133d into main Aug 10, 2023
@JacobMGEvans JacobMGEvans deleted the jacobmgevans/add-more-error-handling branch August 10, 2023 19:54
@github-actions github-actions bot mentioned this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants