-
Notifications
You must be signed in to change notification settings - Fork 202
Closed
Labels
Description
Hi all,
I was wondering why I see some of my environment variables as deployment urls. I would argue that the coding here is not robust enough as I now always get, for example, the posthog endpoint I set as a variable (because it may be us or eu) as my deployment url:
Lines 343 to 349 in b2be7ab
| // If this is a workers or pages deployment, try to extract the deployment URL | |
| let deploymentUrl = ""; | |
| const deploymentUrlMatch = stdOut.match(/https?:\/\/[a-zA-Z0-9-./]+/); | |
| if (deploymentUrlMatch && deploymentUrlMatch[0]) { | |
| deploymentUrl = deploymentUrlMatch[0].trim(); | |
| setOutput("deployment-url", deploymentUrl); | |
| } |
Would be nice if this could be improved.
Reactions are currently unavailable