Skip to content

Secrets truncation #168

@demosjarco

Description

@demosjarco

Uploading a worker with many secrets only partially uploads the secrets but no error or warning is emitted - all success. Looking in the worker dashboard, the secret is simply not listed.
We're way under the 128 combined vars/secrets limit.
Started noticing this behavior on the 11th secret. And the extra secrets (past 10) that doesn't get updated appears to be random (only tested on 3 builds - need more data to be sure about this.
Actions is set to use latest worker version

- uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
  with:
    node-version: lts/*
    check-latest: true
    cache: 'npm'
- uses: cloudflare/wrangler-action@09fc6b504568cf179b085df24393f237fea6c7f6 # v3.1.1
  with:
    wranglerVersion: latest
    apiToken: ${{ secrets... }}
    accountId: ${{ vars... }}
    vars: |
      ...
      ...
    secrets: |
      ...
      ...
      ...
      ...
      ...
      ...
      ...
      ...
      ...
      ...
      ...
  env:
    ...: ${{ vars...}}
    ...: ${{ github...}}
    ...: ${{ secrets...}}
    ...: ${{ secrets...}}
    ...: ${{ secrets...}}
    ...: ${{ secrets... }}
    ...: ${{ secrets... }}
    ...: ${{ secrets... }}
    ...: ${{ secrets...}}
    ...: ${{ secrets... }}
    ...: ${{ secrets...}}
    ...: ${{ secrets... }}
    ...: ${{ secrets...}}

image
This is not a new worker (so I don't think its related to #162), but these are new secrets (compared to previous deployments of the same worker)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions