Skip to content

wrangler containers images delete should prefix the account id by default#9811

Merged
emily-shen merged 1 commit intocloudflare:mainfrom
gpanders:push-qkzvpxovrzvo
Jul 4, 2025
Merged

wrangler containers images delete should prefix the account id by default#9811
emily-shen merged 1 commit intocloudflare:mainfrom
gpanders:push-qkzvpxovrzvo

Conversation

@gpanders
Copy link
Member

@gpanders gpanders commented Jul 1, 2025

Fixes CC-5572.
Fixes #9837

When listing container images with wrangler container images list, we omit the account ID prefix that each container image has in the managed registry. When deleting images we also need to include the account ID.

Also fix an issue with the "containers images list" command where the final line of output was being truncated.

This PR contains two other minor "housekeeping" commits which don't merit their own PR, but were broken out into separate commits to make reviewing easier and to keep the log cleaner:

  • The source files for the containers images command were incorrectly named. Rename them so that registries.ts contains the implementations for the registries subcommand and images.ts contains the implementations for the images subcommand.
  • Tidy up casing and phrasing for some strings in help text output

  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Bug fix
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not in v3

@gpanders gpanders requested review from a team as code owners July 1, 2025 15:47
@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2025

🦋 Changeset detected

Latest commit: 3b3c733

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 1, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9811

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9811

miniflare

npm i https://pkg.pr.new/miniflare@9811

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9811

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9811

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9811

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9811

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9811

wrangler

npm i https://pkg.pr.new/wrangler@9811

commit: 3b3c733

@gpanders gpanders force-pushed the push-qkzvpxovrzvo branch 6 times, most recently from d985145 to 5fb0bb7 Compare July 1, 2025 21:19
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jul 2, 2025
Also fix an issue with the "containers images list" command where the
final line of output was being truncated.
@gpanders gpanders force-pushed the push-qkzvpxovrzvo branch from 4139ced to 3b3c733 Compare July 3, 2025 21:53
@gpanders
Copy link
Member Author

gpanders commented Jul 3, 2025

Resolved conflicts and rebased on main.

@gpanders gpanders enabled auto-merge July 3, 2025 21:54
@gpanders gpanders added this pull request to the merge queue Jul 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 4, 2025
@gpanders gpanders added this pull request to the merge queue Jul 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 4, 2025
@emily-shen emily-shen added this pull request to the merge queue Jul 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 4, 2025
@emily-shen emily-shen added this pull request to the merge queue Jul 4, 2025
Merged via the queue into cloudflare:main with commit fc29c31 Jul 4, 2025
50 of 56 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jul 4, 2025
@workers-devprod workers-devprod mentioned this pull request Jul 4, 2025
@gpanders gpanders deleted the push-qkzvpxovrzvo branch July 7, 2025 16:22
@gpanders gpanders mentioned this pull request Jul 7, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

401 Unauthorized when delete image of containers

3 participants