Skip to content

fix changeset issue with containers-shared#9675

Merged
CarmenPopoviciu merged 2 commits intomainfrom
emily/fix-changeset
Jun 19, 2025
Merged

fix changeset issue with containers-shared#9675
CarmenPopoviciu merged 2 commits intomainfrom
emily/fix-changeset

Conversation

@emily-shen
Copy link
Contributor

allows changesets to mention containers-shared. note tools tests only run on linux.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: tooling change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal tooling
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: package doesn't exist in v3

@emily-shen emily-shen requested a review from a team as a code owner June 19, 2025 12:51
@changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2025

🦋 Changeset detected

Latest commit: 56af520

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/containers-shared Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 19, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9675

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9675

miniflare

npm i https://pkg.pr.new/miniflare@9675

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9675

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9675

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9675

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9675

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9675

wrangler

npm i https://pkg.pr.new/wrangler@9675

commit: 56af520

@@ -0,0 +1,5 @@
---
"@cloudflare/containers-shared": minor
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for posterity...containers-shared was added to workers-sdk without a changeset, and we kept adding /building on top of it without tracking the work with changesets. This brings us back to square one...sort of...so that we can add changesets accordingly for this package from here on <3

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 19, 2025
@CarmenPopoviciu CarmenPopoviciu merged commit caf97e4 into main Jun 19, 2025
33 of 34 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 19, 2025
@CarmenPopoviciu CarmenPopoviciu deleted the emily/fix-changeset branch June 19, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants