Skip to content

fix: ensure that wrangler deploy and version upload don't override the remote-bindings flag#9673

Merged
CarmenPopoviciu merged 2 commits intomainfrom
dario/respect-remote-bindings-flag
Jun 19, 2025
Merged

fix: ensure that wrangler deploy and version upload don't override the remote-bindings flag#9673
CarmenPopoviciu merged 2 commits intomainfrom
dario/respect-remote-bindings-flag

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Jun 19, 2025 •
edited
Loading

Currently wrangler deploy --x-remote-bindings shows incorrect warnings regarding experimental_remote fields:

Screenshot 2025-06-19 at 10 01 47

The changes here are addressing this

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: I'd love it to land this in the next release I can add the tests as a followup if that's ok
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: I need to discuss this with the team
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: not a wrangler v3 feature

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner June 19, 2025 09:34
@changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 5c072a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jun 19, 2025
@dario-piotrowicz dario-piotrowicz added e2e Run wrangler + vite-plugin e2e tests on a PR skip-v3-pr labels Jun 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2025

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main dario/respect-remote-bindings-flag might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-9673
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 19, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9673

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9673

miniflare

npm i https://pkg.pr.new/miniflare@9673

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9673

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9673

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9673

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9673

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9673

wrangler

npm i https://pkg.pr.new/wrangler@9673

commit: 5c072a0

CarmenPopoviciu
CarmenPopoviciu approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing this 🙏

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 19, 2025
@CarmenPopoviciu CarmenPopoviciu merged commit ffa742f into main Jun 19, 2025
32 of 33 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the dario/respect-remote-bindings-flag branch June 19, 2025 11:03
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 19, 2025
@workers-devprod workers-devprod mentioned this pull request Jun 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@penalosa penalosa penalosa approved these changes

+1 more reviewer

@CarmenPopoviciu CarmenPopoviciu CarmenPopoviciu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dario-piotrowicz @CarmenPopoviciu @penalosa