Remove confirmation dialog for cloudchamber apply when not interactive#9664
Remove confirmation dialog for cloudchamber apply when not interactive#9664CarmenPopoviciu merged 1 commit intomainfrom
Conversation
Prior to this the dialog was getting printed but auto-confirmed to yes which is confusing to users.
🦋 Changeset detectedLatest commit: c0cf477 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
| │ [containers.constraints] | ||
| │ tier = 2 | ||
| │ | ||
| ├ Do you want to apply these changes? |
There was a problem hiding this comment.
it seems that all these tests test the non-interactive mode. Is there a reason why interactivity isn't tested for this cmd?
There was a problem hiding this comment.
Just because they weren't added when apply was originally added. Good point they should be added (but maybe not as part of this PR?).
There was a problem hiding this comment.
👍 ...for posterity... Cody added an internal ticket to track adding tests for interactiviy. Will therefore not block this PR on it
Prior to this the dialog was getting printed but auto-confirmed to yes which is confusing to users.