add tag, cleanup containers at end of dev, rebuild hotkey, lots of refactoring etc. etc. by emily-shen · Pull Request #9605 · cloudflare/workers-sdk

emily-shen · 2025-06-13T16:29:14Z

This PR:

moves building into wrangler (called in wrangler, actual code is in containers-shared) DEVX-1991
tears out the container plugin from miniflare, and any container config
Adds a uuid as a tag for images built during dev. Previously we defaulted to latest, which can get into a weird state.
add rebuild hotkey, which resets the build id and cleans up containers from the previous build. (DEVX-1943)
deletes containers at the end of dev session (DEVX-1965)

Sorry this PR does so many things :(

It's been tested manually - e2es to follow up.

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because: will do as followup
Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because:
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s):
- Documentation not necessary because: wip feature
Wrangler V3 Backport
- TODO (before merge)
- Wrangler PR:
- Not necessary because: new feature

changeset-bot · 2025-06-13T16:29:18Z

🦋 Changeset detected

Latest commit: 30c7f91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@cloudflare/containers-shared	Patch
miniflare	Patch
wrangler	Patch
@cloudflare/pages-shared	Patch
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2025-06-13T16:31:50Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9605

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9605

miniflare

npm i https://pkg.pr.new/miniflare@9605

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9605

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9605

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9605

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9605

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9605

wrangler

npm i https://pkg.pr.new/wrangler@9605

commit: 30c7f91

packages/containers-shared/src/utils.ts

packages/miniflare/src/plugins/containers/service/index.ts

packages/containers-shared/src/build.ts

packages/containers-shared/src/knobs.ts

packages/containers-shared/src/types.ts

packages/containers-shared/src/utils.ts

packages/wrangler/src/api/startDevWorker/LocalRuntimeController.ts

packages/wrangler/src/dev/hotkeys.ts

packages/wrangler/src/dev/miniflare.ts

vicb

LGTM, added a few minor comments

github-actions · 2025-06-19T10:44:55Z

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main emily/add-tag might be a good starting point.

Notes:

your PR branch should be named v3-backport-9605
add the skip-v3-pr label to the current PR to stop this workflow from failing

packages/containers-shared/src/build.ts

…r.ts Co-authored-by: Victor Berchet <victor@suumit.com>

Co-authored-by: Carmen Popoviciu <cpopoviciu@cloudflare.com>

workers-devprod added this to workers-sdk Jun 13, 2025

github-project-automation bot moved this to Untriaged in workers-sdk Jun 13, 2025

workers-devprod added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jun 13, 2025

anonrig reviewed Jun 13, 2025

View reviewed changes

packages/containers-shared/src/utils.ts Outdated Show resolved Hide resolved

packages/miniflare/src/plugins/containers/service/index.ts Outdated Show resolved Hide resolved

packages/miniflare/src/plugins/containers/service/index.ts Outdated Show resolved Hide resolved

emily-shen force-pushed the emily/add-tag branch 2 times, most recently from 28dbd89 to 23649aa Compare June 16, 2025 16:43

emily-shen changed the base branch from main to vicb/container-in-do June 17, 2025 08:41

emily-shen changed the base branch from vicb/container-in-do to main June 17, 2025 08:41

emily-shen force-pushed the emily/add-tag branch from 8dc6c69 to 20c9cea Compare June 17, 2025 08:45

emily-shen changed the base branch from main to vicb/container-in-do June 17, 2025 08:47

emily-shen force-pushed the vicb/container-in-do branch from e33be9f to 4366b16 Compare June 17, 2025 15:59

emily-shen force-pushed the emily/add-tag branch from 3e2280b to a2018f8 Compare June 17, 2025 16:16

Base automatically changed from vicb/container-in-do to main June 17, 2025 16:19

emily-shen force-pushed the emily/add-tag branch 4 times, most recently from 796e407 to 43ba1f8 Compare June 17, 2025 17:18

emily-shen changed the title ~~clean up containers at the end of a dev session~~ add tag, cleanup containers at end of dev, rebuild hotkey, lots of refactoring etc. etc. Jun 17, 2025

emily-shen force-pushed the emily/add-tag branch from 58e4a8e to 43ba1f8 Compare June 17, 2025 21:14

emily-shen marked this pull request as ready for review June 18, 2025 08:32

emily-shen requested a review from a team as a code owner June 18, 2025 08:32

emily-shen force-pushed the emily/add-tag branch from 2c3ab13 to 53508df Compare June 18, 2025 12:58