Run CI on behalf of #9416 @8e930470c230bae6c7e58bf888d7619c4385d934#9491
Closed
github-actions[bot] wants to merge 7 commits intomainfrom
Closed
Run CI on behalf of #9416 @8e930470c230bae6c7e58bf888d7619c4385d934#9491github-actions[bot] wants to merge 7 commits intomainfrom
github-actions[bot] wants to merge 7 commits intomainfrom
Conversation
- When a request matches a static routing "exclude" rule, it's directly forwarded to the asset worker. - When a request matches a static routing "include" rule, it's directly forwarded to the user worker. - Otherwise, previous behavior takes over This also adds a new analytics field (double6) for what routing decision was made
vitest yelled at me and told me this should be awaited and may error in future releases
When the Router worker has static routing, the check against "Sec-Fetch-Mode: navigate" is unnecessary. We have explicit static routing to indicate whether or not we should go to a User worker or the Asset worker, and should not try and guess via usually-set browser headers This adds a new parameter to unstable_canFetch RPC method, which should be fine for backwards compatibility, and can be extended in the future if needed. This was necessary because the Asset worker checks the Request headers for Sec-Fetch-Mode to indicate if it can serve an asset (including an index.html or 404.html page based on not_found_handling), but static routing is only provided to the Router worker. Thus, we need to pass more information over RPC
🦋 Changeset detectedLatest commit: d5c5255 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Now that we're not providing this configuration via _routes.json, we can
relax some of the configuration. Much of this happens on the backend,
but some field names have been changed ("include" -> "worker",
"exclude"->"asset") asdfasdf
8e93047 to
d5c5255
Compare
Contributor
Author
|
A Wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465190111/npm-package-wrangler-9491Prereleases for other packages:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465190111/npm-package-cloudflare-workers-bindings-extension-9491 -O ./cloudflare-workers-bindings-extension.0.0.0-va9c0f63c9.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-va9c0f63c9.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465190111/npm-package-create-cloudflare-9491 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465190111/npm-package-cloudflare-kv-asset-handler-9491
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465190111/npm-package-miniflare-9491
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465190111/npm-package-cloudflare-pages-shared-9491
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465190111/npm-package-cloudflare-unenv-preset-9491
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465190111/npm-package-cloudflare-vite-plugin-9491
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465190111/npm-package-cloudflare-vitest-pool-workers-9491
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465190111/npm-package-cloudflare-workers-editor-shared-9491
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465190111/npm-package-cloudflare-workers-shared-9491
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465190111/npm-package-cloudflare-workflows-shared-9491Note that these links will no longer work once the GitHub Actions artifact expires. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR runs CI on behalf of #9416 at commit 8e93047. It can be closed after the CI run is complete.